Implement key success metrics |
|||
Issue descriptionSmartLock.EligibleDevices SmartLock.EnabledState SmartLock.DisabledReason SmartLock.UserDisabled SmartLock.Activation.Success SmartLock.Setup.LaunchMechanism SmartLock.Setup.Result SmartLock.Authentication.Duration SmartLock.Authentication.Duration.Success SmartLock.Authentication.Duration.Failure SmartLock.Activation.Result SmartLock.Authentication.State SmartLock.Authentication.StateTransitions
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a7c9fb7bc29852e30cf09da50f4bc9f0957c81b commit 4a7c9fb7bc29852e30cf09da50f4bc9f0957c81b Author: James Hawkins <jhawkins@chromium.org> Date: Thu Apr 19 20:18:33 2018 SmartLock: Log when the user attempts to enable the feature. I say attempts because there is a chance the setup flow may fail or not be completed. R=hansberry@chromium.org Bug: 831371 Test: none Change-Id: Iecc9255433761428e8529bddaaaed78feaa602b4 Reviewed-on: https://chromium-review.googlesource.com/1020063 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#552141} [modify] https://crrev.com/4a7c9fb7bc29852e30cf09da50f4bc9f0957c81b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
,
Apr 19 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8385ce0219336452bf6617b23194a9d34a4f531c commit 8385ce0219336452bf6617b23194a9d34a4f531c Author: James Hawkins <jhawkins@chromium.org> Date: Fri Apr 20 18:01:50 2018 SmartLock: Log the count of eligible devices to UMA. The log occurs each time devices are (re-)loaded. R=asvitkine@chromium.org, khorimoto@chromium.org Bug: 831371 Test: none Change-Id: I03030039b720980667b6edcdd7cf7b2b4b55b0f2 Reviewed-on: https://chromium-review.googlesource.com/1020464 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552388} [modify] https://crrev.com/8385ce0219336452bf6617b23194a9d34a4f531c/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/8385ce0219336452bf6617b23194a9d34a4f531c/tools/metrics/histograms/histograms.xml
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17a273494097a5f6457f1f705c82205b48e19541 commit 17a273494097a5f6457f1f705c82205b48e19541 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Apr 25 21:50:18 2018 SmartLock: Log the enabled state of the feature at login. The state is 'Enabled' if the user has enabled the feature, 'Disabled' if the user has disabled the feature, and 'Unset' if the user has never enabled the feature. R=asvitkine@chromium.org, hansberry@chromium.org Bug: 831371 Test: none Change-Id: Id7f6207d2763d259cbb117457bc0e968fa6fcd3b Reviewed-on: https://chromium-review.googlesource.com/1026936 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#553770} [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.cc [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.h [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_pref_manager.h [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_pref_names.cc [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_pref_names.h [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.h [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/tools/metrics/histograms/enums.xml [modify] https://crrev.com/17a273494097a5f6457f1f705c82205b48e19541/tools/metrics/histograms/histograms.xml
,
Apr 26 2018
crrev.com/c/1020464 (comment 4) actually logs the count of enabled devices (devices which have been set up to unlock the Chromebook). Logging the count of eligible devices will require a bit more work. In GMSCore v19 the list of |supported_software_features| will be pulled down in ExternalDeviceInfo. This list can be used to count up the number of devices which support SmartLock (and are thus eligible).
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a94eb21bd6dcbaae226197c20e8d582b68857af commit 0a94eb21bd6dcbaae226197c20e8d582b68857af Author: James Hawkins <jhawkins@chromium.org> Date: Wed May 02 22:59:09 2018 SmartLock: Fix the name of the eligible devices count histogram. This is actually the count of enabled devices, not eligible devices. The existing metric, EligibleDevicesCount, will be logged to in a follow-up CL. R=hansberry@chromium.org Bug: 831371 Test: none Change-Id: I38e8a57678f8a9b9d9c23186431147b0961fad43 Reviewed-on: https://chromium-review.googlesource.com/1031182 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#555593} [modify] https://crrev.com/0a94eb21bd6dcbaae226197c20e8d582b68857af/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/0a94eb21bd6dcbaae226197c20e8d582b68857af/tools/metrics/histograms/histograms.xml
,
May 11 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 19 2018