New issue
Advanced search Search tips

Issue 831356 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 831305



Sign in to add a comment

Lower demuxer stream limits even more on 512MiB Android Go devices

Project Member Reported by dskiba@chromium.org, Apr 10 2018

Issue description

In  issue 810906  demuxer limits were changed from 150+2 MiB to 30+1 MiB on low-end Android devices in order to reduce renderer footprint to avoid being killed by Android.

That helped, but is not enough - Chrome is still being killed after ~40 minutes of Youtube playback.

We need to reduce demuxer limits more.

And we don't need to care about 1080p - Chrome dies after 10 seconds of 1080p playback, mainly because media-related Android processes use too much memory.


 

Comment 1 by dskiba@chromium.org, Apr 10 2018

Blocking: 831305

Comment 2 by dskiba@chromium.org, Apr 10 2018

Lowering demuxer limits is only one part of the approach, see parent  issue 831305 .
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85c20a7e8e8692e5875b2655b1f8ef826ee02900

commit 85c20a7e8e8692e5875b2655b1f8ef826ee02900
Author: Dmitry Skiba <dskiba@chromium.org>
Date: Thu Apr 12 18:58:01 2018

Use "very low" demuxer limits on 512MiB Android Go devices.

Right now low end Android devices use "low" demuxer limits, the
same limits used by Chromecast.

Turned out that even with low limits Chrome is still dangeoursly
close to being killed by Android. Plus, we don't need to care
about playing 1080p on 512MiB Go devices (consideration used by
Chromecast to select low values).

Bug:  831356 
Change-Id: I8161f133ae71881ea29108ffa8b5a5175a841e8c
Reviewed-on: https://chromium-review.googlesource.com/1006071
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550289}
[modify] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/BUILD.gn
[modify] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/demuxer_memory_limit.h
[add] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/demuxer_memory_limit_android.cc
[delete] https://crrev.com/8c59ba5c4bcb6dd38610f26b960538ed8e23b35f/media/base/demuxer_memory_limit_select.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85c20a7e8e8692e5875b2655b1f8ef826ee02900

commit 85c20a7e8e8692e5875b2655b1f8ef826ee02900
Author: Dmitry Skiba <dskiba@chromium.org>
Date: Thu Apr 12 18:58:01 2018

Use "very low" demuxer limits on 512MiB Android Go devices.

Right now low end Android devices use "low" demuxer limits, the
same limits used by Chromecast.

Turned out that even with low limits Chrome is still dangeoursly
close to being killed by Android. Plus, we don't need to care
about playing 1080p on 512MiB Go devices (consideration used by
Chromecast to select low values).

Bug:  831356 
Change-Id: I8161f133ae71881ea29108ffa8b5a5175a841e8c
Reviewed-on: https://chromium-review.googlesource.com/1006071
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550289}
[modify] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/BUILD.gn
[modify] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/demuxer_memory_limit.h
[add] https://crrev.com/85c20a7e8e8692e5875b2655b1f8ef826ee02900/media/base/demuxer_memory_limit_android.cc
[delete] https://crrev.com/8c59ba5c4bcb6dd38610f26b960538ed8e23b35f/media/base/demuxer_memory_limit_select.cc

Comment 5 by dskiba@chromium.org, Apr 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment