SkTypeface::filterRec's Rec modification not replicated in SkTypefaceProxy |
|
Issue descriptionRan into this when testing a push based approach for font remoting in chrome. SkTypeface can modify the recs generated using SkScalerContext::MakeRecAndEffects. In font remoting, the actual typeface lives in the renderer and is backed by a SkTypefaceProxy. Since this proxy doesn't replicate the same modifications as would be made by the typeface in the renderer, it results in inconsistent recs between the renderer and the gpu. This in particular came up when pushing fonts from the renderer to the gpu since these inconsistent recs were resulting in cache misses.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66ca223f23195cc90ed23f92cf661719157e00ee commit 66ca223f23195cc90ed23f92cf661719157e00ee Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 06:38:43 2018 Roll src/third_party/skia/ c86c5c014..ef4142a9b (2 commits) https://skia.googlesource.com/skia.git/+log/c86c5c0144b8..ef4142a9bc5f $ git log c86c5c014..ef4142a9b --date=short --no-merges --format='%ad %ae %s' 2018-05-01 khushalsagar fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache. 2018-05-01 angle-skia-autoroll Roll third_party/externals/angle2/ ad3aaeba3..57d9cbb67 (4 commits) Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2eaec4a83a8936edf0b814259456d4a1846f6008 Reviewed-on: https://chromium-review.googlesource.com/1038822 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555322} [modify] https://crrev.com/66ca223f23195cc90ed23f92cf661719157e00ee/DEPS
,
May 2 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/192b18a26164e8e188f8aad0a376c7bee2cea226 commit 192b18a26164e8e188f8aad0a376c7bee2cea226 Author: Mike Klein <mtklein@google.com> Date: Wed May 02 13:53:18 2018 Revert "fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache." This reverts commit ef4142a9bc5fb5fe3158139e18f41e7da867ff93. Reason for revert: 2 of 5 Original change's description: > fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache. > > Since the typeface proxies on the client don't perform the same > filtering done on the server during SkDescriptor generation, it causes > the desc mismatches during raster. Disable this filtering on the server > until this is resolved. > > Bug: 831354 > Change-Id: I5683372fb497a4874dede5aec9c734cd1392872c > Reviewed-on: https://skia-review.googlesource.com/125140 > Commit-Queue: Khusal Sagar <khushalsagar@chromium.org> > Reviewed-by: Herb Derby <herb@google.com> TBR=herb@google.com,khushalsagar@chromium.org Change-Id: I8e732f57aa49323c186e3c4ea6120ff1caf8e25b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831354 Reviewed-on: https://skia-review.googlesource.com/125261 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> [modify] https://crrev.com/192b18a26164e8e188f8aad0a376c7bee2cea226/src/core/SkRemoteGlyphCache.cpp [modify] https://crrev.com/192b18a26164e8e188f8aad0a376c7bee2cea226/src/core/SkScalerContext.cpp [modify] https://crrev.com/192b18a26164e8e188f8aad0a376c7bee2cea226/src/core/SkScalerContext.h [modify] https://crrev.com/192b18a26164e8e188f8aad0a376c7bee2cea226/tests/SkRemoteGlyphCacheTest.cpp
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af650571273676119bde851aab4e8d7d73ece49 commit 9af650571273676119bde851aab4e8d7d73ece49 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 18:36:54 2018 Roll src/third_party/skia/ 2050565fe..f9ab22385 (11 commits) https://skia.googlesource.com/skia.git/+log/2050565fe116..f9ab22385ead $ git log 2050565fe..f9ab22385 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 robertphillips Modify SkGpuBlurUtils::GaussianBlur's reexpand method and allow more approx fit intermediates 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms 33bdf05..513d372 (1 commits) 2018-05-01 herb Reland "Remove devKerning" 2018-05-01 herb Take sk_sp<SkDevice> instead of SkDevice* 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms a1c0fe6..33bdf05 (1 commits) 2018-05-02 kjlubick Add public repro instructions for repoducing fuzzers 2018-05-02 mtklein Revert "fonts: Set up remote glyph caching to push fonts." 2018-05-02 mtklein Revert "Remove devKerning" 2018-05-02 mtklein Revert "fonts: Dont memcpy with nullptr in SkRemoteGlyphCache" 2018-05-02 mtklein Revert "fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache." 2018-05-02 mtklein Revert "Add padding back to make msan happy" Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ic58c56833d60fbd583fbf671a31cfb3fb94eb975 Reviewed-on: https://chromium-review.googlesource.com/1039772 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555484} [modify] https://crrev.com/9af650571273676119bde851aab4e8d7d73ece49/DEPS
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90525c18a37810c51731a9f99638bce6c7d2bfea commit 90525c18a37810c51731a9f99638bce6c7d2bfea Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 21:05:38 2018 Roll src/third_party/skia/ f9ab22385..38a084368 (7 commits; 1 trivial rolls) https://skia.googlesource.com/skia.git/+log/f9ab22385ead..38a08436886e $ git log f9ab22385..38a084368 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 khushalsagar fonts: Reland push font remoting. 2018-05-02 reed check for finite vertices 2018-05-02 angle-skia-autoroll Roll third_party/externals/angle2/ 47155b171..78feddc28 (5 commits) 2018-05-02 reed use SkLeftShift in case the first arg is negative 2018-05-02 reed check for 0x8000 before calling abs 2018-05-01 herb Add the filter rec bypass to make canonical strike descriptors Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2e0bf369d9581b066ce31b0c003b9c5a14482f9b Reviewed-on: https://chromium-review.googlesource.com/1040529 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555521} [modify] https://crrev.com/90525c18a37810c51731a9f99638bce6c7d2bfea/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, May 1 2018