New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831350 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 831337



Sign in to add a comment

[Findit] Add .pass_fail_counts attribute to webkit_layout_tests

Project Member Reported by chanli@chromium.org, Apr 10 2018

Issue description

Add .pass_fail_counts attribute to webkit_layout_tests so that Findit recipes can understand test results and find culprit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f

commit b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f
Author: Chan <chanli@chromium.org>
Date: Sat Apr 14 00:37:02 2018

[Findit] Add pass_fail_counts to python-based tests.

Add pass_fail_counts to SwarmingIsolatedScriptTest and LocalIsolatedScriptTest.

Also modified the logic of processing test_results to support repeat case.

Bug:  831350 
Change-Id: I07eb28eab8bf9fec527d4c6b6c47a8f225b88891
Reviewed-on: https://chromium-review.googlesource.com/1011458
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/test_utils/util.py
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipes/findit/chromium/flake.py
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_isolated_script_test.py
[add] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_isolated_script_test.expected/log_pass_fail_counts.json
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipes/findit/chromium/test.py
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/customized_test_options.json
[add] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/chromium_tests/steps.py
[add] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipes/findit/chromium/test.expected/webkit_layout_tests.json
[modify] https://crrev.com/b45ebc6bb0ee03f6b84a43ec3861a97d48e9c22f/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py

Comment 2 by chanli@chromium.org, Apr 14 2018

Status: Fixed (was: Assigned)

Sign in to add a comment