New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831345 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 831337



Sign in to add a comment

[Findit] Add test_options to SwarmingIsolatedScriptTest

Project Member Reported by chanli@chromium.org, Apr 10 2018

Issue description

This is to enable Findit recipes to add necessary flags to run selected tests n times for webkit_layout_tests
 

Comment 1 by chanli@chromium.org, Apr 10 2018

Blocking: 831337
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7761d1abecfbbbc8390672f2653f0a05b1c882d9

commit 7761d1abecfbbbc8390672f2653f0a05b1c882d9
Author: Chan <chanli@chromium.org>
Date: Fri Apr 13 17:52:03 2018

Add test_options to SwarmingIsolatedScriptTest and LocalIsolatedScriptTest.

Findit using test_options to set args like test_filter, repeat_count, retry_limit and run_disabled so that Findit can run specific tests n times try jobs.

Adding test_options to SwarmingIsolatedScriptTest and LocalIsolatedScriptTest to add support for webkit_layout_tests

Bug:  831345 
Change-Id: I7fd6ce3dc1f29f81175566db21c1e10280933f28
Reviewed-on: https://chromium-review.googlesource.com/1006067
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/7761d1abecfbbbc8390672f2653f0a05b1c882d9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py
[modify] https://crrev.com/7761d1abecfbbbc8390672f2653f0a05b1c882d9/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_isolated_script_test.py
[add] https://crrev.com/7761d1abecfbbbc8390672f2653f0a05b1c882d9/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_isolated_script_test.expected/customized_test_options.json
[add] https://crrev.com/7761d1abecfbbbc8390672f2653f0a05b1c882d9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/customized_test_options.json
[modify] https://crrev.com/7761d1abecfbbbc8390672f2653f0a05b1c882d9/scripts/slave/recipe_modules/chromium_tests/steps.py

Comment 3 by chanli@chromium.org, Apr 14 2018

Status: Fixed (was: Started)

Sign in to add a comment