New issue
Advanced search Search tips

Issue 831340 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Omnibox font size changed, (perhaps unintentionally?)

Project Member Reported by dpa...@chromium.org, Apr 10 2018

Issue description

Bisected to https://chromium.googlesource.com/chromium/src/+log/a10903c12db18d128bced4e73f4a9e7c4d9d9d56..44076c740a2e13b4bf76b9fb21adf7dd2d2c1d08

Most likely related to https://chromium.googlesource.com/chromium/src/+/44076c740a2e13b4bf76b9fb21adf7dd2d2c1d08.

It is unclear to me if that change is supposed to be behind a flag. I am reproducing without any flags enabled on my Linux machine ToT.

Assigning to tommycli@ for triage.
 
font_size_changed.png
11.2 KB View Download
font_size_before.png
3.7 KB View Download

Comment 1 by dpa...@chromium.org, Apr 10 2018

Components: UI>Browser>Omnibox
Status: Assigned (was: Untriaged)
Labels: Hotlist-Polish
Labels: -Pri-3 Pri-2
Looks like this is Linux only, as I can't repro on Windows.
Cc: pkasting@chromium.org
Owner: tapted@chromium.org
Sending to tapted as he submitted the original CL. I'm not sure if this change is intentional or not.

Comment 6 by tapted@chromium.org, Apr 13 2018

I'm OOO until ~May - the logic wasn't meant to change anywhere "under a default user config" unless a flag was flipped, but there are lots of variables (especially on desktop-linux).

The intent of the code is to use a 14pt font under a "default user config", which assumes GTK's default font size is 12pt. Basically, 2pt are added. So if user settings have GTKs default font size at 13pt, omnibox will be 15pt, etc. Unless GTK's default font size is much larger, then it will cap to whatever fits in the omnibox.

I think the code before r545332 didn't take into account the user setting for the default GTK font size. The logic just asked the resource bundle for a 14pt font, and if the result was 14pt it would use it. But now, if the user settings specify a larger default font size, that gets taken into account.
Hmm. Okay. Well, we have 11pt as our default font size as our workstations.

It looks like before r545332, we used 11pt as the Omnibox font size.

Now, it looks like we use 13pt font as the Omnibox font size, which is consistent with your statement that Omnibox font size should be 2 points larger than the default GTK font size.

Are you saying it was previously incorrect and the change to a bigger font on Linux is intentional? If so, we can close the bug.

The bigger font does look better to me.


Cc: jdonnelly@chromium.org
If the change is intentional and therefore here to stay, are there ways to set a lower font size specifically for the Omnibox through Chrome and/or GTK theming? Lowering the system font size makes the rest of the UI too small, but I'd definitely prefer smaller text in the Omnibox, still.
Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09115274d6833e9a49a905cc81df26ec5b815e35

commit 09115274d6833e9a49a905cc81df26ec5b815e35
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 04 06:49:03 2018

Hardcode Omnibox font size at 14 (ignore user and locale settings).

r545332 preserved the omnibox font size of 14 for default user OS
configurations but inadvertently started applying scaling logic used
for dialog text that the omnibox text field never used. It is 14pt.
Always.

Revert to the old behaviour.

Importantly, the way the size delta was being captured would fail to
shrink a font that was too large to fit, if that delta came from user
settings rather than font metrics alone.

Bug:  831340 ,  838065 
Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f
Reviewed-on: https://chromium-review.googlesource.com/1041390
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556004}
[modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/chrome_typography.cc
[modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/chrome_typography.h
[modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/layout_provider_unittest.cc

Fixed? Or is there more to do here?
Status: Fixed (was: Assigned)
I have a merge request in  Issue 838065 . This can be marked fixed though.

In a separate issue, we may also want to revisit whether we actually _do_ want to take into account locale and user settings for the font size for the omnibox. E.g. arabic and devenagari scripts have large descenders (so fonts tend to be designed with smaller glyphs, on average). In Chrome, locale settings bump up the default font size for these, but the omnibox currently ignores this, even though there's plenty of room to fit a larger font (there's less room in the omnibox decorations/chips though).

Also FTR, my default-configured glinux Cinnamon desktop did not have an increased font size. So the specifics the size increase here really do seem to come from a linux desktop config that is asking for a larger default font size. (But then, who can really say what is "default" when it comes to Desktop Linux :/)
Project Member

Comment 13 by bugdroid1@chromium.org, May 8 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab972de732ecb207beccdc99809eec1b200d48da

commit ab972de732ecb207beccdc99809eec1b200d48da
Author: Trent Apted <tapted@chromium.org>
Date: Tue May 08 00:42:05 2018

[merge-m67] Hardcode Omnibox font size at 14 (ignore user and locale settings).

r545332 preserved the omnibox font size of 14 for default user OS
configurations but inadvertently started applying scaling logic used
for dialog text that the omnibox text field never used. It is 14pt.
Always.

Revert to the old behaviour.

Importantly, the way the size delta was being captured would fail to
shrink a font that was too large to fit, if that delta came from user
settings rather than font metrics alone.

TBR=tapted@chromium.org

(cherry picked from commit 09115274d6833e9a49a905cc81df26ec5b815e35)

Bug:  831340 ,  838065 
Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f
Reviewed-on: https://chromium-review.googlesource.com/1041390
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556004}
Reviewed-on: https://chromium-review.googlesource.com/1049085
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#511}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/chrome_typography.cc
[modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/chrome_typography.h
[modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/layout_provider_unittest.cc

Sign in to add a comment