New issue
Advanced search Search tips

Issue 831334 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: Apr 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox displays download URL if download is open in a new Tab

Project Member Reported by eugene...@chromium.org, Apr 10 2018 
App Version (from "Chrome Settings > About Chrome"): M67
iOS Version: All
Device: All

Steps to reproduce: 
1. Load https://developer.apple.com/fonts/
2. Long Press on Download button.
3. Tap on Open in Newtab in context menu.

Observed behavior: 
Omnibox displays Download URL

Expected behavior: 
Omnibox should display the URL for the currently rendered page (about:blank)
Also it is not possible to verify security state of displayed URL, so it is better to show about:blank.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3a6034a65b11598d1dfa714b88449dc36ba3641

commit d3a6034a65b11598d1dfa714b88449dc36ba3641
Author: Eugene But <eugenebut@google.com>
Date: Wed Apr 11 17:17:04 2018

Discard download pending items and stop the load.

Omnibox should display the URL for the currently rendered
page (about:blank), not download URL. Also added StopLoading
call to hide the progress indicator.

Bug:  831334 ,  824148 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I47eddd9ef7a46480383a60a1425f2c69513cf129
Reviewed-on: https://chromium-review.googlesource.com/1005893
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549916}
[modify] https://crrev.com/d3a6034a65b11598d1dfa714b88449dc36ba3641/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
[modify] https://crrev.com/d3a6034a65b11598d1dfa714b88449dc36ba3641/ios/web/web_state/ui/crw_web_controller.mm

Comment 2 by eugene...@chromium.org, Apr 11 2018

Status: Fixed (was: Started)

Comment 3 by subhashi...@chromium.org, Apr 17 2018

Status: Verified (was: Fixed)
Verified in:

App Version: 68.0.3398.0 canary
Devices: iPhone 7, iPhone X, iPad Air
iOS Versions: 10.3.3, 11.4 beta 1

Omnibox displays the URL for the currently rendered page(about:blank) instead of download URL when a link is opened in NTP from context menu.
►

Sign in to add a comment