Issue metadata
Sign in to add a comment
|
VR: Control container still hidden after exiting WebVR presentation |
||||||||||||||||||||||||||
Issue descriptionGo to 03-presentation Insert phone into headset Go through DON flow Take phone out of headset Exit presentation with the 'x' button.
,
Apr 10 2018
M67 regression, not present in M66. Should be bisectable.
,
Apr 12 2018
bisecting.
,
Apr 12 2018
(This will probably need to be merged)
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a commit 93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Apr 13 00:32:37 2018 VR: Allow control container to hide before showing it again Reverts some code I thought wasn't necessary anymore in https://chromium-review.googlesource.com/c/chromium/src/+/951926 Bug: 831332 Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885 Reviewed-on: https://chromium-review.googlesource.com/1011406 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550434} [modify] https://crrev.com/93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Apr 13 2018
,
Apr 13 2018
,
Apr 16 2018
,
Apr 16 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a commit 93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Apr 13 00:32:37 2018 VR: Allow control container to hide before showing it again Reverts some code I thought wasn't necessary anymore in https://chromium-review.googlesource.com/c/chromium/src/+/951926 Bug: 831332 Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885 Reviewed-on: https://chromium-review.googlesource.com/1011406 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550434} [modify] https://crrev.com/93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Apr 17 2018
'revert' keyword is a red herring...
,
Apr 17 2018
,
Apr 17 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e2c34abc1ebe0371b4bf8a29bd250f91c252cbc commit 0e2c34abc1ebe0371b4bf8a29bd250f91c252cbc Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Apr 18 14:21:51 2018 VR: Allow control container to hide before showing it again Reverts some code I thought wasn't necessary anymore in https://chromium-review.googlesource.com/c/chromium/src/+/951926 TBR=mthiesse@chromium.org (cherry picked from commit 93fa1f7e84ff7a1c63d5f567ccbdfe603d5d189a) Bug: 831332 Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885 Reviewed-on: https://chromium-review.googlesource.com/1011406 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550434} Reviewed-on: https://chromium-review.googlesource.com/1016687 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#78} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0e2c34abc1ebe0371b4bf8a29bd250f91c252cbc/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Apr 18 2018
,
May 8 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by mthiesse@chromium.org
, Apr 10 2018