ChromeSitePerProcessTest failures with User Activation v2 |
||
Issue descriptionWe currently have 4 test failures with User Activation v2, and they don't seem to work even after our proposed fix for Issue 780556 ! - PopupWindowFocus - PostMessageSendsSecondPostMessageWithUserGesture - TwoPostMessagesToDifferentSitesWithSameUserGesture - TwoPostMessagesWithSameUserGesture At least some of these tests seem to rely on user activation too much through ExecuteScript*() methods. The last one doesn't currently fail but a fix (that selectively uses uses ExecuteScriptWithoutUserGesture etc) seems to expose the over reliance. We need to clarify the user activation expectations in these tests, and fix them for UAv2.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc2f610e55fabe4a85e666c536eef7f6824e5551 commit cc2f610e55fabe4a85e666c536eef7f6824e5551 Author: Mustaq Ahmed <mustaq@google.com> Date: Thu Apr 19 21:08:32 2018 Fixed PopupWindowFocus for UAv2. Also cleanup other tests' dependency on user activation. Bug: 831331 Change-Id: Ic2268318336d64e0031fe782ec4c48b9d91ae36b Reviewed-on: https://chromium-review.googlesource.com/1006047 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#552155} [modify] https://crrev.com/cc2f610e55fabe4a85e666c536eef7f6824e5551/chrome/browser/chrome_site_per_process_browsertest.cc [modify] https://crrev.com/cc2f610e55fabe4a85e666c536eef7f6824e5551/content/renderer/render_view_impl.cc [modify] https://crrev.com/cc2f610e55fabe4a85e666c536eef7f6824e5551/third_party/blink/renderer/core/loader/frame_loader.cc
,
Apr 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Apr 10 2018