New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831323 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: Apr 2018
Cc:
█ elizabethchiu@chromium.org
ovanieva@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

KSH window need to be centered in the screen

Project Member Reported by wutao@chromium.org, Apr 10 2018 
There are three situations:

1. If there is a browser window already opened, the KSH is opened at the center.

2. If there is no window, the KSH is opened at the top-left corner.

3. If there is no window, and the KSH is opened from launcher, the KSH window is at the center.

Need to investigate why 2 happens and not consistent.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95d39a245ccaf0cc2d8176702840865d575413d

commit b95d39a245ccaf0cc2d8176702840865d575413d
Author: wutao <wutao@chromium.org>
Date: Wed Apr 11 06:51:28 2018

cros: Shortcuts window should center in screen

The Shortcuts window is not centered in screen when there is no context.
This cl fix this bug.

Bug:  831323 
Test: KeyboardShortcutViewTest.CenterWindowInScreen
Change-Id: I968450240ce2f69edc607a16aad1f48760138559
Reviewed-on: https://chromium-review.googlesource.com/1006066
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549800}
[modify] https://crrev.com/b95d39a245ccaf0cc2d8176702840865d575413d/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/b95d39a245ccaf0cc2d8176702840865d575413d/ash/components/shortcut_viewer/views/keyboard_shortcut_view_unittest.cc
[modify] https://crrev.com/b95d39a245ccaf0cc2d8176702840865d575413d/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/b95d39a245ccaf0cc2d8176702840865d575413d/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc

Comment 2 by wutao@chromium.org, Apr 12 2018

Status: Fixed (was: Available)
►

Sign in to add a comment