virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html is flaky |
||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of georgesak@chromium.org ...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg) Builders failed on: - WebKit Linux Trusty (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29
,
Apr 12 2018
The test fails constantly. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/11506 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/11507
,
Apr 12 2018
I cannot find which CL triggers this. Network team, could you triage this?
,
Apr 12 2018
It's probably been broken since it was added: https://chromium-review.googlesource.com/c/chromium/src/+/979835 I will add a flaky expectation for it.
,
Apr 12 2018
This may be related to issue 391068 ("Layout Test http/tests/websocket/workers/close-code-and-reason.html is flaky").
,
Apr 12 2018
It doesn't flake locally on my workstation (failed 0 times out of 1000), but since it is timing-dependent, that is not too surprising.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/256e6c0df82f23cd0a9fcc65ea72d0883f01c84a commit 256e6c0df82f23cd0a9fcc65ea72d0883f01c84a Author: Adam Rice <ricea@chromium.org> Date: Thu Apr 12 14:01:17 2018 Mark close-code-and-reason.html flaky in virtual Mark virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html as flaky. BUG= 831320 Change-Id: I388617a9d8269da334bfa3d1de1cdafbb8203efb Reviewed-on: https://chromium-review.googlesource.com/1009782 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550176} [modify] https://crrev.com/256e6c0df82f23cd0a9fcc65ea72d0883f01c84a/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 12 2018
Assigning to nhiroki@. If it's still flaky once everything else is working, I will take another look at it.
,
Apr 17 2018
,
May 1 2018
The flag virtual/off-main-thread-websocket has change from "enabled" to "disabled", and http/tests/websocket/close-code-and-reason.html hasn't started flaking, so I think this is fixed now.
,
May 7 2018
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c6bbdd7086dcda02461bcd3256fb9c2b13fb3f5 commit 5c6bbdd7086dcda02461bcd3256fb9c2b13fb3f5 Author: Adam Rice <ricea@chromium.org> Date: Wed May 09 04:55:20 2018 Re-enable .../off-main-thread/.../close-code-and-reason.html Layout test virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html was flaky with early versions of the off-main-thread WebSocket implementation. It is no longer flaky, and this virtual test suite has been switched to running the old "on main thread" WebSocket implementation. So the flaky expectation is no longer needed. Remove it. Bug: 831320 Change-Id: I6bb6b2430dbc0fbfad3c5e4ca629487cffaac7a3 Reviewed-on: https://chromium-review.googlesource.com/1036765 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#557096} [modify] https://crrev.com/5c6bbdd7086dcda02461bcd3256fb9c2b13fb3f5/third_party/WebKit/LayoutTests/TestExpectations |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by peria@chromium.org
, Apr 11 2018