New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 781754



Sign in to add a comment

Support WebResourceRequest.isRedirect in the WebView Support Library

Project Member Reported by gsennton@chromium.org, Apr 10 2018

Issue description

Corresponding buganizer bug:
b/74939930
 
Cc: ntfschr@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0

commit 2d2cfcad371cbc548d7a46a0bbedb200190fbfe0
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Apr 12 15:46:46 2018

[android webview] Support WebResourceRequestCompat.isRedirect()

Add code to support the Support Library version of
WebResourceRequest.isRedirect().
Also add a feature flag to guard that API.

Bug:  831315 
Change-Id: I528c02cfabdd1a83f66231ed7dd1b78b972b3843
Reviewed-on: https://chromium-review.googlesource.com/1005755
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550217}
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/glue/java/src/com/android/webview/chromium/WebResourceRequestAdapter.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/BUILD.gn
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/BUILD.gn
[add] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebResourceRequestBoundaryInterface.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebkitToCompatConverterBoundaryInterface.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[add] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebResourceRequest.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0

commit 2d2cfcad371cbc548d7a46a0bbedb200190fbfe0
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Apr 12 15:46:46 2018

[android webview] Support WebResourceRequestCompat.isRedirect()

Add code to support the Support Library version of
WebResourceRequest.isRedirect().
Also add a feature flag to guard that API.

Bug:  831315 
Change-Id: I528c02cfabdd1a83f66231ed7dd1b78b972b3843
Reviewed-on: https://chromium-review.googlesource.com/1005755
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550217}
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/glue/java/src/com/android/webview/chromium/WebResourceRequestAdapter.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/BUILD.gn
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/BUILD.gn
[add] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebResourceRequestBoundaryInterface.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebkitToCompatConverterBoundaryInterface.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[add] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebResourceRequest.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
[modify] https://crrev.com/2d2cfcad371cbc548d7a46a0bbedb200190fbfe0/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java

Are we planning to merge this fix to M67 Branch ?
No need to merge, this CL made it before branch point (landed in 67.0.3396.0).
Thanks Nate for clarification . Please add the Manual verification steps if necessary .

Sign in to add a comment