New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831306 link

Starred by 1 user
Status: Fixed
Owner:
█ ltian@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Change "Download page" to "Download link" in Browser Actions

Project Member Reported by sbirch@chromium.org, Apr 10 2018 
Follow-up from launch review -- we should change the string to match the text in Chrome. In theory this should just be a pointer to the existing string, so it shouldn't need any new translations. (I don't think it's blocking regardless; likely too late for 66 as-is.)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eba23a115b4d3e5a2dc58a9d4ecd31e5becc4434

commit eba23a115b4d3e5a2dc58a9d4ecd31e5becc4434
Author: Lei Tian <ltian@chromium.org>
Date: Fri Jun 08 19:46:27 2018

Fix Browser Actions bugs

This CL fixes Browser Actions bugs includes:
1. Change download menu text to "Download link".
2. Fix flaky test.

Bug: 773073,  831306 
Change-Id: I4f2bc4d9288c2d96b7d878eb80ac0802e8065fe3
Reviewed-on: https://chromium-review.googlesource.com/1091875
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565718}
[modify] https://crrev.com/eba23a115b4d3e5a2dc58a9d4ecd31e5becc4434/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/eba23a115b4d3e5a2dc58a9d4ecd31e5becc4434/chrome/android/javatests/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java

Comment 2 by ltian@chromium.org, Jun 8 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment