ToolsPopupMenuTestCase.testNoSearchForPDF fails under UIRefreshPhase1 |
|||
Issue descriptionThere are a few issues with this test: 1) The new code should use grey_accessibilityID(kToolsMenuFindInPageId) as the matcher for the FIP button. 2) The test is looking for an AX=Y element with UIAccessibilityTraitNotEnabled. When I inspect in the simulator, the cells appear to be AX=N and are missing the "NotEnabled" trait. 3) It doesn't scroll the tools menu. I don't think that's causing this test to fail, but we should fix while we're in here. I have a CL that fixes #1 and #3 and I can send it out if you'd like. I'm not sure how to handle #2, because I don't know what you were planning for a11y for these cells. It's easy enough to add UIAccessiblityTraitNotEnabled as appropriate, but I don't know what to do about the cells being AX=N.
,
Apr 11 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1152c50a0b3f36b0b8cb6a95408d1b020d4c2479 commit 1152c50a0b3f36b0b8cb6a95408d1b020d4c2479 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Apr 11 16:16:56 2018 Add accessibility trait to popup menu cells This CL adds the accessibility trait button to the popup menu cells. It also adds the accessibility trait NotEnabled when the entry is disabled. Bug: 831290 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b7e91c9a7328dbc94a9c1dfff5621ba92b16164 Reviewed-on: https://chromium-review.googlesource.com/1007275 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549904} [modify] https://crrev.com/1152c50a0b3f36b0b8cb6a95408d1b020d4c2479/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm [modify] https://crrev.com/1152c50a0b3f36b0b8cb6a95408d1b020d4c2479/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm [modify] https://crrev.com/1152c50a0b3f36b0b8cb6a95408d1b020d4c2479/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm
,
Apr 11 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rohitrao@chromium.org
, Apr 10 2018