MIME Sniffer is not CRX₃ Compatible |
|||
Issue descriptionCRX₃ is not sniffed as the correct mime type by net/base/mime_sniffer.cc.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/450258caf4b2019711d1c5d09d2dd8d3003df58f commit 450258caf4b2019711d1c5d09d2dd8d3003df58f Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Apr 11 15:11:40 2018 Expand CRX magic number list in sniffer for CRX3 Bug: 831284 Change-Id: I84d27cfb61725524d1ec9b12ffaa1bda221529ff Reviewed-on: https://chromium-review.googlesource.com/1005797 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#549887} [modify] https://crrev.com/450258caf4b2019711d1c5d09d2dd8d3003df58f/net/base/mime_sniffer.cc [modify] https://crrev.com/450258caf4b2019711d1c5d09d2dd8d3003df58f/net/base/mime_sniffer_unittest.cc
,
Apr 11 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0c0fe296a8b3cfe657207e7772303c603e9498 commit ff0c0fe296a8b3cfe657207e7772303c603e9498 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 18:35:25 2018 [Extensions] Add a new test for mime-type sniffing Expand a mime type sniffing test to include testing a newly-minted crx. This ensures that we always recognize the modern crx packaging as the extensions mime type. Bug: 831284 Change-Id: I4622b9eb0911c76a59cf0c25068f8e9dffd97977 Reviewed-on: https://chromium-review.googlesource.com/1005843 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550283} [modify] https://crrev.com/ff0c0fe296a8b3cfe657207e7772303c603e9498/chrome/common/extensions/DEPS [modify] https://crrev.com/ff0c0fe296a8b3cfe657207e7772303c603e9498/chrome/common/extensions/extension_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0c0fe296a8b3cfe657207e7772303c603e9498 commit ff0c0fe296a8b3cfe657207e7772303c603e9498 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 18:35:25 2018 [Extensions] Add a new test for mime-type sniffing Expand a mime type sniffing test to include testing a newly-minted crx. This ensures that we always recognize the modern crx packaging as the extensions mime type. Bug: 831284 Change-Id: I4622b9eb0911c76a59cf0c25068f8e9dffd97977 Reviewed-on: https://chromium-review.googlesource.com/1005843 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550283} [modify] https://crrev.com/ff0c0fe296a8b3cfe657207e7772303c603e9498/chrome/common/extensions/DEPS [modify] https://crrev.com/ff0c0fe296a8b3cfe657207e7772303c603e9498/chrome/common/extensions/extension_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by waff...@chromium.org
, Apr 10 2018