New issue
Advanced search Search tips

Issue 831283 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Omnibox] add unit test for ExtractJsonData

Project Member Reported by dschuyler@chromium.org, Apr 10 2018

Issue description

A SearchSuggestionParser exposes three functions. There are some tests for DeserializeJsonData and ParseSuggestResults at components/omnibox/browser/search_suggestion_parser_unittest.cc

We still need a test for ExtractJsonData.  The "net/url_request_test_url_fetcher_factory.h" looks like it will be helpful in creating this test.

https://cs.chromium.org/chromium/src/components/omnibox/browser/search_suggestion_parser.h?type=cs&q=search_suggestion_parser&l=293

 
Components: Tests>Missing

Sign in to add a comment