Replace usages of DictionaryValue/ListValues with map/array and remove the mojom types |
||||||
Issue descriptionSince the new values.typemap maps Value, DictionaryValue and ListValue to base::Value, DictionaryValue and ListValue from //mojo/public/mojom/base/values.mojom can be removed and their usages replaced with array<Value> and map<string, Value>. List of files referencing *Value mojom type can be found in http://sheets/1e3K3Z4jYnD6qNemi7e1s7LW-x13Q2AToQXexV7yGSs4#gid=0
,
Apr 19 2018
,
Apr 26 2018
,
Apr 26 2018
,
May 2 2018
Postponing the changes until the Value class is updated to allow easy conversion to and from base::flat_map<std::string, base::Value>, which is a part of https://crbug.com/646113.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dac2b0cc2dbf00e12dea5d05cb6292353718e88 commit 1dac2b0cc2dbf00e12dea5d05cb6292353718e88 Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Wed May 02 21:26:50 2018 Update profile_import.mojom to use map instead of DictionaryValue Bug: 831261 Change-Id: I507b031f970464c346d4dcef40537edd5fd7e116 Reviewed-on: https://chromium-review.googlesource.com/1033724 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555557} [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/browser/importer/external_process_importer_client.cc [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/common/importer/profile_import.mojom [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/utility/importer/external_process_importer_bridge.cc [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/utility/importer/external_process_importer_bridge.h [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/utility/importer/profile_import_impl.cc [modify] https://crrev.com/1dac2b0cc2dbf00e12dea5d05cb6292353718e88/chrome/utility/importer/profile_import_impl.h
,
Oct 17
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by oksamyt@chromium.org
, Apr 10 2018