New issue
Advanced search Search tips

Issue 831253 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 831811

Blocking:
issue 888692



Sign in to add a comment

ozone_gl_unittests fail on eve

Project Member Reported by kylec...@chromium.org, Apr 10 2018

Issue description

I tried running ozone_gl_unittests on eve and as far as I can tell all the test cases timeout and fail. Here are some logs from running one of the tests on eve.

localhost /opt/google/chrome # ./ozone_gl_unittests --gtest_also_run_disabled_tests --gtest_filter="DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage"
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from DISABLED_GLImageNativePixmap/GLImageBindTest/1, where TypeParam = <type>
[ RUN      ] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage
Still waiting for the following processes to finish:
	./ozone_gl_unittests --gtest_also_run_disabled_tests --gtest_filter=DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage --gtest_flagfile=/tmp/.org.chromium.Chromium.fkxIBy/.org.chromium.Chromium.y88NJY --single-process-tests --test-launcher-output=/tmp/.org.chromium.Chromium.jY6Ct8/test_results.xml
Still waiting for the following processes to finish:
	./ozone_gl_unittests --gtest_also_run_disabled_tests --gtest_filter=DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage --gtest_flagfile=/tmp/.org.chromium.Chromium.fkxIBy/.org.chromium.Chromium.y88NJY --single-process-tests --test-launcher-output=/tmp/.org.chromium.Chromium.jY6Ct8/test_results.xml
[1/1] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage (TIMED OUT)
1 test timed out:
    DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage (../../ui/gl/test/gl_image_test_template.h:202)
Tests took 45 seconds.
 
I believe this is a regression. These tests use to work. Daniele: can you note when you last successfully ran these tests on device and the flags you used?
It doesn't go past ui::OzonePlatform::InitializeForGPU.

I don't remember last time we ran the tests successfully, but since they're not run on any trybot (we don't have Chromebooks on trybots) they often end up broken when ozone initialization changes.
Seems to get stuck in drm_device_ptr_->StartDrmDevice(&success) in HostDrmDevice::BlockingStartDrmDevice.
Owner: rjkroege@chromium.org
Status: Assigned (was: Available)
Cc: mcasas@chromium.org
ccing Miguel that is planning to add ozone_gl_unittests to autotests as soon as this is fixed.

Comment 6 by mcasas@chromium.org, Apr 12 2018

Blocking: 831811
Status: Started (was: Assigned)
On chell, the situation has now been altered:

 ./ozone_gl_unittests --gtest_also_run_disabled_tests --gtest_filter="DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage"

Gives

IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from DISABLED_GLImageNativePixmap/GLImageBindTest/1, where TypeParam = <type>
[ RUN      ] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage
../../ui/ozone/gl/gl_image_ozone_native_pixmap_unittest.cc:60: Failure
Value of: image->Initialize(pixmap.get(), pixmap->GetBufferFormat())
  Actual: false
Expected: true
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8d8468df gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_image_test_template.h:223: Failure
Value of: rv
  Actual: false
Expected: true
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8d846a70 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 1, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 2, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 3, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 4, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 5, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 6, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 255, which exceeds error, where
expected evaluates to 255,
actual evaluates to 0, and
error evaluates to 0.
 at 7, 0 channel 1
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 240, which exceeds error, where
expected evaluates to 240,
actual evaluates to 0, and
error evaluates to 0.
 at 8, 0 channel 0
Stack trace:
#0 0x5e5d8d86582b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x5e5d8d865196 testing::internal::AssertHelper::operator=()
#2 0x5e5d8dc0f033 gl::GLTestHelper::CheckPixelsWithError()
#3 0x5e5d8d846b77 gl::gtest_case_GLImageBindTest_::BindTexImage<>::TestBody()

[  FAILED  ] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage, where TypeParam = <type> (53 ms)
[----------] 1 test from DISABLED_GLImageNativePixmap/GLImageBindTest/1 (53 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (53 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage, where TypeParam = <type>

 1 FAILED TEST
Failed to get out-of-band test success data, dumping full stdio below:

[1/1] DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage (0 ms)
1 test failed:
    DISABLED_GLImageNativePixmap/GLImageBindTest/1.BindTexImage (../../ui/gl/test/gl_image_test_template.h:197)
Tests took 0 seconds.

Blockedon: 831811
Blocking: -831811
rjkroege@ any updates? The ozone_gl_unittests is running in all platforms
via autotest, and failing.
Components: OS>Kernel>Graphics
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cad8bd5cd31e3b3a898f131ecbabe28480408fdb

commit cad8bd5cd31e3b3a898f131ecbabe28480408fdb
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Thu Oct 18 00:10:27 2018

graphics_Chrome: fix test.

Somehow the cherry_pick of the arguments is going wrong, move
decorator.

BUG=b:117897907, crbug.com/831253
TEST=locally on caroline-arcnext.

Change-Id: I5a562859a35f941fd2750b5458f74a9f4dec75a8
Reviewed-on: https://chromium-review.googlesource.com/c/1287489
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>

[modify] https://crrev.com/cad8bd5cd31e3b3a898f131ecbabe28480408fdb/client/site_tests/graphics_Chrome/graphics_Chrome.py

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c09573dc20762e4c9f67a50018ffe6e82ba30e01

commit c09573dc20762e4c9f67a50018ffe6e82ba30e01
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Thu Oct 18 00:43:16 2018

graphics_Chrome: fix test.

Somehow the cherry_pick of the arguments is going wrong, move
decorator.

BUG=b:117897907, crbug.com/831253
TEST=locally on caroline-arcnext.

Change-Id: I5a562859a35f941fd2750b5458f74a9f4dec75a8
Reviewed-on: https://chromium-review.googlesource.com/c/1287489
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>
(cherry picked from commit cad8bd5cd31e3b3a898f131ecbabe28480408fdb)
Reviewed-on: https://chromium-review.googlesource.com/c/1287609
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/c09573dc20762e4c9f67a50018ffe6e82ba30e01/client/site_tests/graphics_Chrome/graphics_Chrome.py

Labels: -Pri-3 M-72 Pri-2
rjkroege, these are still failing e.g. on eve (pixelbook) and nautilus, so it should be
pretty easy to repro.

I just compiled ozone_gl_unittests, copied it to my chromebook and ran it. Gdb told 
that, essentially HostDrmDevice::BlockingStartDrmDevice() sends a sync mojo 
StartDrmDevice to the DrmThread:

#8  in ui::ozone::mojom::DrmDeviceProxy::StartDrmDevice(bool*) () at gen/ui/ozone/public/interfaces/drm_device.mojom.cc:217
#9  in ui::HostDrmDevice::BlockingStartDrmDevice() () at ../../ui/ozone/platform/drm/host/host_drm_device.cc:70
#10 in ui::(anonymous namespace)::OzonePlatformGbm::InitializeGPU(ui::OzonePlatform::InitParams const&) () at ../../ui/ozone/platform/drm/ozone_platform_gbm.cc:276
#11 in ui::OzonePlatform::InitializeForGPU(ui::OzonePlatform::InitParams const&) () at ../../ui/ozone/public/ozone_platform.cc:88

DrmThread doesn't seem to be doing anything:

(gdb) info threads
  Id   Target Id         Frame 
* 1    Thread 0x7ffff7dfe740 (LWP 30924) "ozone_gl_unitte" pthread_cond_wait () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  2    Thread 0x7ffff6b77700 (LWP 30928) "TaskSchedulerSe" 0x00007ffff6fde5b3 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84
  3    Thread 0x7ffff6376700 (LWP 30929) "TaskSchedulerFo" pthread_cond_wait () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  4    Thread 0x7ffff5b75700 (LWP 30930) "TaskSchedulerFo" pthread_cond_wait () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  5    Thread 0x7ffff512c700 (LWP 30931) "DrmThread" 0x00007ffff6fde5b3 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84

but it's not being woken up by the StartDrmDevice (which should be received
by DrmThread::StartDrmDevice() [1]). DrmThread::Start() and Init() have been
correctly called.


[1] https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/drm_thread.cc?type=cs&q=DrmThread::StartDrmDevice&sq=package:chromium&g=0&l=364
Blocking: 888692
rjkroege@ any news on this?
Owner: ----
Status: Available (was: Started)
Realistically, I don't have time to look at this for several weeks.

Sign in to add a comment