New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

third-party/ffmpeg OWNERS file causes presubmit to fail

Project Member Reported by jcivelli@chromium.org, Apr 10 2018

Issue description

My Chrome CL https://chromium-review.googlesource.com/c/chromium/src/+/966925 adds a new dependency to third-party/ffmpeg which causes the presubmit step to fail in the owners check.
third-party/ffmpeg/OWNERS references media/OWNERS with a relative path causing owners.py to fail finding it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/272be0ac4cae282d827732759c300fd2c5077827

commit 272be0ac4cae282d827732759c300fd2c5077827
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Apr 10 18:04:07 2018

Make OWNERS file not reference outside of this repo

This CL changes the OWNERS file to be a copy of the reviewers in
media/OWNERS instead of referencing it. Referencint it with a relative
path was causing failures in the owner check of the presubmit.

Bug:  831242 
Change-Id: I37583482276510d699a9fefc67bcf1c30e384290
Reviewed-on: https://chromium-review.googlesource.com/1005714
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>

[modify] https://crrev.com/272be0ac4cae282d827732759c300fd2c5077827/OWNERS

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb4a780521d167f9ab582a4b3682ab97327dd00

commit 7eb4a780521d167f9ab582a4b3682ab97327dd00
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Apr 10 22:57:15 2018

Roll src/third_party/ffmpeg/ f34a90b21..272be0ac4 (1 commit)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f34a90b21090..272be0ac4cae

$ git log f34a90b21..272be0ac4 --date=short --no-merges --format='%ad %ae %s'
2018-04-10 jcivelli Make OWNERS file not reference outside of this repo

Created with:
  roll-dep src/third_party/ffmpeg

Bug:  831242 
Change-Id: I89e269c3b6db30de1318b70bfdc0ae84fcdf1f70
Reviewed-on: https://chromium-review.googlesource.com/1005630
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549668}
[modify] https://crrev.com/7eb4a780521d167f9ab582a4b3682ab97327dd00/DEPS

Status: Fixed (was: Untriaged)

Sign in to add a comment