2D UI - Unexpected dialog displayed outside VR Browsing |
||||||||
Issue descriptionChrome Version: 67.0.3390.1 Canary OS: android 8.1.0 on Pixel 2 What steps will reproduce the problem? From the Autofill popup test case: ----------------------------- (1) Navigate to https://rsolomakhin.github.io/autofill/ (2) Enter VR Browsing (3) Click Submit on the "Credit Card autofill" form, this should open https://example.com page. (4) Use the Refresh button on the Overflow menu. What is the expected result? The specific dialog is expected based on scenario outside VR. But the dialog should be presented inside VR Browsing. What happens instead? While in VR Browsing the specific dialog is presented outside VR.
,
Apr 10 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10 commit 14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10 Author: Biao She <bshe@chromium.org> Date: Fri Apr 13 00:19:27 2018 Making RepostFormWarningDialog shows up in VR Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479 This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are in VR. Bug: 831233 Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff Reviewed-on: https://chromium-review.googlesource.com/1010916 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550431} [modify] https://crrev.com/14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10/chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
,
Apr 13 2018
The UI should be showing in VR now.
,
Apr 16 2018
,
Apr 17 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23a75c187d4c3e8f1d06cfb977d5610fca98698d commit 23a75c187d4c3e8f1d06cfb977d5610fca98698d Author: Biao She <bshe@chromium.org> Date: Tue Apr 17 16:26:43 2018 Making RepostFormWarningDialog shows up in VR Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479 This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are in VR. TBR=bshe@chromium.org (cherry picked from commit 14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10) Bug: 831233 Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff Reviewed-on: https://chromium-review.googlesource.com/1010916 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550431} Reviewed-on: https://chromium-review.googlesource.com/1014717 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#41} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/23a75c187d4c3e8f1d06cfb977d5610fca98698d/chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10 commit 14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10 Author: Biao She <bshe@chromium.org> Date: Fri Apr 13 00:19:27 2018 Making RepostFormWarningDialog shows up in VR Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479 This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are in VR. Bug: 831233 Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff Reviewed-on: https://chromium-review.googlesource.com/1010916 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550431} [modify] https://crrev.com/14a6d4db2c124be74a22ee0a16e0bb6e11ce8d10/chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
,
May 8 2018
Verified on build 67.0.3396.29 beta. Looks good. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dougman@chromium.org
, Apr 10 2018273 KB
273 KB View Download