New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: 1
NextAction: 2018-04-25
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 820586



Sign in to add a comment

RemoteServiceException: Bad notification posted on Marshmallow Coolpad devices

Project Member Reported by awdf@chromium.org, Apr 10 2018

Issue description

e.g. 

Bad notification posted from package com.android.chrome: Couldn't update icon: StatusBarIcon(icon=Icon(typ=RESOURCE pkg=com.android.chrome id=0x00000000) visible user=0 )
at android.app.ActivityThread$H.handleMessage	(ActivityThread.java:1536 )
at android.os.Handler.dispatchMessage	(Handler.java:102 )
at android.os.Looper.loop	(Looper.java:148 )
at android.app.ActivityThread.main	(ActivityThread.java:5609 )
at java.lang.reflect.Method.invoke	(Native Method )
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run	(ZygoteInit.java:797 )
at com.android.internal.os.ZygoteInit.main	(ZygoteInit.java:687 )

We already disabled badges for Samsung Marshmallow devices at  Issue 829367 , we may need to do the same for Coolpad Marshmallow devices too, but worth repro-ing and proving the fix on a device first. (Also need to check what Build.MANUFACTURER reports on one of these devices to put in the device-specific fallback)

Crash link (includes Samsung devices too):

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid%20Java%20Exception%5D%20android.app.RemoteServiceException%20at%20android.app.ActivityThread%24H.handleMessage(ActivityThread.java)%27%20AND%20EXISTS%20(SELECT%201%20FROM%20UNNEST(thread)%20WHERE%20StackTrace.error_message%3D%27Bad%20notification%20posted%20from%20package%20com.android.chrome%3A%20Couldn%5C%27t%20update%20icon%3A%20StatusBarIcon(icon%3DIcon(typ%3DRESOURCE%20pkg%3Dcom.android.chrome%20id%3D0x00000000)%20visible%20user%3D0%20)%27)%20AND%20expanded_custom_data.ChromeCrashProto.channel%3D%27stable%27
 

Comment 1 by awdf@chromium.org, Apr 10 2018

Have ordered a Coolpad 3600I for testing. Will take this up when I receive the device.

Comment 2 by awdf@chromium.org, Apr 10 2018

NextAction: 2018-04-25

Comment 3 by awdf@chromium.org, Apr 10 2018

Blocking: 820586
The NextAction date has arrived: 2018-04-25
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/463b699604bbc16c1e3b29e4a60dce9c6cbe1fdd

commit 463b699604bbc16c1e3b29e4a60dce9c6cbe1fdd
Author: Anita Woodruff <awdf@chromium.org>
Date: Fri Apr 27 18:34:17 2018

[Android] Disable custom status bar notification icons on M Coolpads

- Use the fallback Chrome logo instead of attempting to set a custom
badge as the status bar icon for all web notifications on Marshmallow
Coolpad devices, same as what we do on Samsung Marshmallow devices, to
avoid a crash.

- Tested with a Coolpad 3600i (the model experiencing most of the
non-Samsung crashes) which reports its Build.MANUFACTURER to be
'YuLong'.

R=nyquist@chromium.org

Bug:  831220 
Change-Id: Id475bbda198c7c61fbb4d114bb562826ffd351e5
Reviewed-on: https://chromium-review.googlesource.com/1028271
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554428}
[modify] https://crrev.com/463b699604bbc16c1e3b29e4a60dce9c6cbe1fdd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] https://crrev.com/463b699604bbc16c1e3b29e4a60dce9c6cbe1fdd/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java

Comment 6 by na...@chromium.org, May 2 2018

Thanks for this fix Anita! Are there any other next actions here or can we mark this fixed now?

Sign in to add a comment