New issue
Advanced search Search tips

Issue 831219 link

Starred by 29 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Sign in to add a comment

[MacViews-Browser] Implement Cocoa Fullscreen behaviors onto MacViews

Project Member Reported by meh...@chromium.org, Apr 10 2018

Issue description

Chrome Version: Canary 67.0.3393.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Go into Native Fullscreen Mode

What is the expected result?
To see Tabstrip/Toolbar/Bookmarksbar like in Cocoa Mode.

What happens instead?
Tabstrip/Toolbar/Bookmarksbar are missing in Native Fullscreen Mode. 


Please use labels and text to provide additional information.
I haven't found an open bugreport, so I thought to file one :-)


Thanks
Mehmet

 
Cc: -sdy@chromium.org
Labels: M-68 MacViews-Browser Target-68
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Thanks for filing these bugs, mehmet@ :) it's very helpful to have your eyes on this.

Comment 2 by meh...@chromium.org, Apr 12 2018

 Issue 832256  has been merged into this issue.

Comment 3 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 4 by sdy@chromium.org, May 25 2018

Labels: -Pri-2 -M-68 -Target-68 Target-69 M-69 Pri-1
Hmm, I think this is P1. Otherwise, it totally changes the behavior of fullscreen on Mac.

Comment 5 by weili@chromium.org, Jun 1 2018

@sdy, do you want me to take this if you haven't started? I stumbled this while investigating 835068, they may be related.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d420e64d93157a657f1f73af263267f973040e0

commit 2d420e64d93157a657f1f73af263267f973040e0
Author: Wei Li <weili@chromium.org>
Date: Tue Jun 05 16:48:28 2018

Handle top view status correctly for Mac full screen mode

On Mac, by default the top view (tab strip and toolbar etc.) should show
up unless the user explicitly toggle the option to hide the top view.
So, this CL fixes whether to hide the top view according to whether it
is in full screen mode as well as user's choice.

This CL also adds a test to make sure the top view's status is correct
across all platforms, especially on Mac.

BUG= 835068 , 835067 ,831219

Change-Id: Iaec1c2eba5eebff5f012e6f02ca73a5aa0a8a08d
Reviewed-on: https://chromium-review.googlesource.com/1086123
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564541}
[modify] https://crrev.com/2d420e64d93157a657f1f73af263267f973040e0/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/2d420e64d93157a657f1f73af263267f973040e0/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc

Comment 7 by sdy@chromium.org, Jun 5 2018

weili@: Sure!

Comment 8 by sdy@chromium.org, Jun 5 2018

Owner: weili@chromium.org
Labels: TE-Verified-69.0.3451.0 TE-Verified-M69
Verified the fix on Mac 10.13.1 using Chrome version #69.0.3451.0 as per the comment#0.
Attaching screen shot for reference.
Observed the Tabstrip/Toolbar/Bookmarksbar in Native Fullscreen Mode. 
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 67.0.3393.0

Thanks...!!
831219.png
214 KB View Download

Comment 11 by sdy@chromium.org, Jun 6 2018

This is a huge improvement, but some things are still missing:

- The toolbar should show/hide if I change the setting while in fullscreen.

- The window controls are missing from the toolbar in fullscreen and there's a blank space where they would be (you can see Safari for the super native behavior, and look at Cocoa Chrome's behavior. Try moving your mouse to the top of the screen and then away to show/hide the menu bar.)

- When you move your mouse to the top of the screen, or hit Cmd+L to focus the location bar, the toolbar should temporarily drop down.
Thanks weili@. 

One more point to sdy@'s c#11:

If you detach a tab when in fullscreen, a new fullscreen window is immediately created. It shouldn't until you lift finger from the mouse button. Thanks :)
Status: Started (was: Assigned)
Summary: [MacViews-Browser] Implement Cocoa Fullscreen behaviors onto MacViews (was: [MacViews-Browser] Tabstrip/Toolbar/Bookmarksbar are missing in Native Fullscreen Mode)
Thanks @sdy, @mehnet, for all the feedback. I didn't mark this bug as fixed as I noticed some of the issues @sdy mentioned too.

I agree there are more work to port Cocoa fullscreen behaviors to MacViews. Let's use the bug to track them.
@mehmet, sorry for the typo in #13

Comment 15 by sdy@chromium.org, Jun 9 2018

Blockedon: 851261
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1

commit 9bb543155ad47d11896d32cbb71cdce3d5b8d8f1
Author: Wei Li <weili@chromium.org>
Date: Thu Jun 21 16:48:20 2018

[MacViews] Show/hide top UI in fullscreen mode correctly

Unlike Windows and Linux, Mac allows top UI to show or hide in browser
fullscreen mode. Also this option can be toggled at runtime to make the
change. But in tab fullscreen mode, top UI should always hide. These
require propagating fullscreen and user preference changes, recording
the toolbar styles and applying the layout accordingly.

This CL makes sure the top chrome UI status is correct across different
fullscreen modes, and responds to user changes as well. Some tests are
also added.

BUG= 851261 ,831219, 852779 
TEST=Pls check the toolbar/tabstrip show or hide correctly when
entering and exiting various fullscreen modes. Bookmark bar, slide-down
menu and traffic lights will be fixed later.

Change-Id: I78a2b68821d5e633ac5c2823f65390809a57dad5
Reviewed-on: https://chromium-review.googlesource.com/1102026
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569301}
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_frame_mac.h
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_frame_mac.mm
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/9bb543155ad47d11896d32cbb71cdce3d5b8d8f1/ui/views/widget/native_widget_mac.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83950fc6c2d04db185355e2fff6fb981e886303

commit c83950fc6c2d04db185355e2fff6fb981e886303
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Jun 21 21:34:30 2018

Revert "[MacViews] Show/hide top UI in fullscreen mode correctly"

This reverts commit 9bb543155ad47d11896d32cbb71cdce3d5b8d8f1.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 569301 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzliYjU0MzE1NWFkNDdkMTE4OTZkMzJjYmI3MWNkY2UzZDViOGQ4ZjEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/41389

Sample Failed Step: interactive_ui_tests

Original change's description:
> [MacViews] Show/hide top UI in fullscreen mode correctly
> 
> Unlike Windows and Linux, Mac allows top UI to show or hide in browser
> fullscreen mode. Also this option can be toggled at runtime to make the
> change. But in tab fullscreen mode, top UI should always hide. These
> require propagating fullscreen and user preference changes, recording
> the toolbar styles and applying the layout accordingly.
> 
> This CL makes sure the top chrome UI status is correct across different
> fullscreen modes, and responds to user changes as well. Some tests are
> also added.
> 
> BUG= 851261 ,831219, 852779 
> TEST=Pls check the toolbar/tabstrip show or hide correctly when
> entering and exiting various fullscreen modes. Bookmark bar, slide-down
> menu and traffic lights will be fixed later.
> 
> Change-Id: I78a2b68821d5e633ac5c2823f65390809a57dad5
> Reviewed-on: https://chromium-review.googlesource.com/1102026
> Commit-Queue: Wei Li <weili@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569301}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 851261 ,831219, 852779 

Change-Id: I2447ccf0b3a960a4e017dcf957d044bff8ae2433
Reviewed-on: https://chromium-review.googlesource.com/1110898
Cr-Commit-Position: refs/heads/master@{#569379}
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_frame_mac.h
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_frame_mac.mm
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/c83950fc6c2d04db185355e2fff6fb981e886303/ui/views/widget/native_widget_mac.h

Labels: MacViews-Release
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab

commit 0eadb78c0a33c57f92d339be5139c0c0d7bc53ab
Author: Wei Li <weili@chromium.org>
Date: Fri Jun 22 23:27:07 2018

Reland "[MacViews] Show/hide top UI in fullscreen mode correctly"

The original CL https://crrev.com/c/1102026 got reverted due to failed
test BrowserViewTest.BrowserFullscreenShowTopView on
"Mac ASan 64 Tests (1)" bot. The failure is most likely due to
that the system preference for "always show toolbar in full screen"
may be different on different bots. This CL explicitly set up the
preference at the beginning of the test.

Original change's description:
> [MacViews] Show/hide top UI in fullscreen mode correctly
>
> Unlike Windows and Linux, Mac allows top UI to show or hide in browser
> fullscreen mode. Also this option can be toggled at runtime to make the
> change. But in tab fullscreen mode, top UI should always hide. These
> require propagating fullscreen and user preference changes, recording
> the toolbar styles and applying the layout accordingly.
>
> This CL makes sure the top chrome UI status is correct across different
> fullscreen modes, and responds to user changes as well. Some tests are
> also added.
>
> BUG= 851261 ,831219, 852779 
> TEST=Pls check the toolbar/tabstrip show or hide correctly when
> entering and exiting various fullscreen modes. Bookmark bar, slide-down
> menu and traffic lights will be fixed later.
>
> Change-Id: I78a2b68821d5e633ac5c2823f65390809a57dad5
> Reviewed-on: https://chromium-review.googlesource.com/1102026
> Commit-Queue: Wei Li <weili@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569301}

Change-Id: I37a2641b5a578dabcf922792158c0f13b2e197e8
Reviewed-on: https://chromium-review.googlesource.com/1111015
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569836}
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_frame_mac.h
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_frame_mac.mm
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab/ui/views/widget/native_widget_mac.h

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7bf866517d115fcd6056443eafa0dfa10d9c82

commit 9a7bf866517d115fcd6056443eafa0dfa10d9c82
Author: Wei Li <weili@chromium.org>
Date: Tue Jun 26 03:53:21 2018

[MacViews] Track fullscreen bookmark bar state correctly

Mac browser fullscreen mode allows to keep the top UI, as well as
toggling between showing and hiding the top UI. In these cases, bookmark
bar should always show or hide in sync with the top UI. This requires
tracking top UI change, and change bookmark bar state or visibility
accordingly.

In Views, bookmark bar state is cached in Browser::bookmark_bar_state_,
and is updated through Browser::UpdateBookmarkBarState(). So when the
visibility of top UI changes, we need to execute
UpdateBookmarkBarState() to update bookmark bar state as well.

BUG=831219
TEST=pls check bookmark bar (non-detached) in fullscreen mode, which
     should always show or hide along with toolbar/tabstrip.

Change-Id: I04475edc455a62e045857ed666c44a31ead2b402
Reviewed-on: https://chromium-review.googlesource.com/1109405
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570324}
[modify] https://crrev.com/9a7bf866517d115fcd6056443eafa0dfa10d9c82/chrome/browser/ui/browser.cc
[modify] https://crrev.com/9a7bf866517d115fcd6056443eafa0dfa10d9c82/chrome/browser/ui/browser.h
[modify] https://crrev.com/9a7bf866517d115fcd6056443eafa0dfa10d9c82/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/9a7bf866517d115fcd6056443eafa0dfa10d9c82/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc

Labels: -MacViews-Release
Labels: -M-69 Group-Full_Screen_Support
Labels: M-69
Labels: ReleaseBlock-Stable
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7d78be694eb9d2c623ec19776f3457b3dec0049

commit c7d78be694eb9d2c623ec19776f3457b3dec0049
Author: Wei Li <weili@chromium.org>
Date: Thu Jul 12 21:27:41 2018

[MacViews] Reduce the height of title bar in fullscreen

In fullscreen mode, the height of the title bar should be as regular
size, not as the regular tab strip height.

We can not create a new class for fullscreen since that will trigger an
NSThemeFrame assert error in
reacquireToolbarViewFromFullScreenWindowAndShow(); we can not directly
check styleMask in _titleHeight() function because that may not reflect
its fullscreen status. This CL introduces a variable and records
its fullscreen status in setStyleMask(). The title bar height is
decided based on that variable.

BUG= 825968 ,831219

Change-Id: I2e827e31f6e7769344584e2ff9ddd5c4efedc419
Reviewed-on: https://chromium-review.googlesource.com/1132135
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574726}
[modify] https://crrev.com/c7d78be694eb9d2c623ec19776f3457b3dec0049/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8

commit dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8
Author: Wei Li <weili@chromium.org>
Date: Tue Jul 17 17:05:22 2018

[MacViews] Control fullscreen top UI with mouse and menu tracking

In fullscreen, when the mouse moves to the upper border of the screen, a
slide-down menu will show. When the user enables showing toolbar in
fullscreen, a native title bar will also appear. In such case, our tab
strip and toolbar should show underneath the title bar.

This CL reuses the Cocoa browser's menu and mouse tracking classes, and
implements a Views based FullscreenToolbarController to track the mouse
activities and menu progress so the top UI would show in appropriate
position.

BUG=831219

Change-Id: Ia30c9cb74819a866ae39cc3e696affb94350efbf
Reviewed-on: https://chromium-review.googlesource.com/1130001
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575690}
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
[add] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_cocoa.h
[add] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_cocoa.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm
[add] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.h
[add] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.h
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/dc764bb8ffc51e8aa2d977721a6a2cfd9afa12c8/ui/views/cocoa/bridged_native_widget.h

Thank you weili@. Your latest change from c#26 is now in latest Canary. I'm seeing still some edge cases comparing to Cocoa. I think you are still working fixing issue regarding to this report. Should I file separate reports for the issues that I am seeing though or should I wait until your work is completely done on this report? Thanks :)
This also regressed  Issue 418413 : The toolbar hides while the mouse is still over it, instead of when the mouse fully leaves it.

Comment 29 Deleted

jleedev@ Can you please open a new report for it and post the bug number here? Thanks.
Thanks. Updated  bug 865155 . 
I am fixing 864931 and 865155 right now. And I also have an outstanding CL 1121053 which may be punted to later.

mehmet@, feel free to file bugs. We can always check whether they are dups or of high/low priority. 

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1406837c85633743729c75ec61f02e45b852f1f2

commit 1406837c85633743729c75ec61f02e45b852f1f2
Author: Wei Li <weili@chromium.org>
Date: Thu Jul 19 17:10:31 2018

[MacViews] Track mouse and position content correctly in fullscreen

During full screen mode, we need to track mouse movement around top UI
to lock the system menu bar. This CL sets up the correct area for such
tracking.

Also, when system menu bar slides down in full screen, only the top UI
will appears under the menu bar while the position of web content should
not move.

BUG= 864931 , 865155 , 831219

Change-Id: Ie121e6f27dd24066c1ae1e133740f01c75f118a5
Reviewed-on: https://chromium-review.googlesource.com/1142694
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576533}
[modify] https://crrev.com/1406837c85633743729c75ec61f02e45b852f1f2/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/1406837c85633743729c75ec61f02e45b852f1f2/chrome/browser/ui/views/frame/browser_view_layout.cc

Owner: sdy@chromium.org
Blockedon: 865901
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Blockedon: 868398
Blockedon: 868382
Labels: -M-69 -Target-69 M-70 Target-70
Blockedon: 850873
I'm trying to figure out if a regression I'm seeing is wrapped up in this issue before submitting a new issue.

On Mac Canary 71.0.3546.0, and in latest Mac Chrome 69.0.3497.81, when in full screen mode (ctrl-cmd-f) and with the tab/location bar hidden using 'always show toolbar in full screen' set to off (cmd-shift-f), two things that used to work are now broken: 

1. Moving the mouse to the top of the screen used to temporarily reveal the tab/location bar so one could select a different tab or change locations

2. cmd-l used to temporarily reveal and activate the location bar so one could type a new location/URL (once entered, the tab/location bar would re-hide).

In latest Chrome and Canary (and in some previous Canary version I believe), moving the mouse to the top of screen no longer reveals the tab/location bar (just the window title bar), and cmd-l does nothing ... it doesn't reveal the tab/location bar nor does it activate a bar that can be typed in.

Is this current issue fixing what I've described above and/or are these issues appropriate here? If not, happy to file a new issue.
bgrosser@: Thanks for your comment. I think the two points you are mention are tracked with issue 868398. 
Blocking: 882199

Comment 45 Deleted

Blocking: -882199
Blockedon: 882199
Blockedon: 883910
Blockedon: 884436
Blockedon: 885009
 Issue 888253  has been merged into this issue.
Blockedon: 883870
 Issue 905038  has been merged into this issue.
Cc: susan.boorgula@chromium.org
 Issue 905346  has been merged into this issue.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***Mass UI Triage***
As per comments
Issue 868398 hasn't been updated since December 27th, and comments are closed. It has been >3 months since the original issue was posted and there's still no fix. Could we have an update on the status of this bug fix?

Sign in to add a comment