Media Controls: Split modernMediaControls.css into seperate stylesheets |
|||
Issue descriptionmodernMediaControls.css is getting quite large and every rule we add is a persistent memory overhead. We should break out this CSS file with separate stylesheets for immersive and testing (and anything else) so we avoid adding rules that are not used all the time.
,
Apr 19 2018
Note that I will be splitting out the VR sheet as part of crbug.com/834458
,
Apr 23 2018
Actually, we went a different route for solving that issue, so I did not split out the VR sheet
,
May 2 2018
,
Dec 19
What work still needs to be done on this, if any?
,
Dec 19
Pretty much all of it. modernMediaControls.css is currently a 1300+ line monolith CSS file that's only slightly organized. At a minimum, we want to split out the rules that are only used in special cases (e.g. immersive/testing as mentioned above) and only load those when necessary. It may not be worth the overhead to further split out rules that are always loaded, though it would make the CSS much more readable
,
Dec 20
It's also work mentioning that modernMediaControls.css is a UA stylesheet, which means that every rule is added to every page on Chrome so if we could move some of these rules out into a separate stylesheet it should improve performance.
,
Jan 11
This issue has been marked as started, but has no owner. Making available. |
|||
►
Sign in to add a comment |
|||
Comment 1 by beccahughes@chromium.org
, Apr 10 2018Status: Started (was: Available)