New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831211 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 829310



Sign in to add a comment

"Transfer/FileManagerBrowserTest.Test/3" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 10 2018

Issue description

"Transfer/FileManagerBrowserTest.Test/3" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMQsSBUZsYWtlIiZUcmFuc2Zlci9GaWxlTWFuYWdlckJyb3dzZXJUZXN0LlRlc3QvMww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
 Issue 832190  has been merged into this issue.
Looks like it's a general issue that affects tests that involve transferring to Drive - seeing an issue with /6, which is "transferFromOfflineToDrive".
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978a6eb4783a8950432d57ef0d0dff862d6bfd3e

commit 978a6eb4783a8950432d57ef0d0dff862d6bfd3e
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Apr 12 22:13:57 2018

Disable flaky transfer tests which have Drive targets in FileManagerBrowserTest.

TBR=fukino@chromium.org

Bug:  831211 
Change-Id: I173d35915b89bcd346d473d41f01db718808574c
Reviewed-on: https://chromium-review.googlesource.com/1010829
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550384}
[modify] https://crrev.com/978a6eb4783a8950432d57ef0d0dff862d6bfd3e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Had a further flake with Transfer/FileManagerBrowserTest.Test/1:
https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/102743

Comment 6 by noel@chromium.org, Apr 16 2018

Cc: yamaguchi@chromium.org mtomasz@chromium.org fukino@chromium.org
Owner: noel@chromium.org

Comment 7 by noel@chromium.org, Apr 16 2018

Components: Platform>Apps>FileManager

Comment 8 by noel@chromium.org, Apr 16 2018

Problem:

26571:26571:0416/085250.685243:FATAL:private_api_file_system.cc(810)] Check failed: external_backend->CanHandleType(file_system_url.type()). GURL: type: -1

When that CHECK stop happens, we always see other failure modes as well.  That is the case here.

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978a6eb4783a8950432d57ef0d0dff862d6bfd3e

commit 978a6eb4783a8950432d57ef0d0dff862d6bfd3e
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Apr 12 22:13:57 2018

Disable flaky transfer tests which have Drive targets in FileManagerBrowserTest.

TBR=fukino@chromium.org

Bug:  831211 
Change-Id: I173d35915b89bcd346d473d41f01db718808574c
Reviewed-on: https://chromium-review.googlesource.com/1010829
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550384}
[modify] https://crrev.com/978a6eb4783a8950432d57ef0d0dff862d6bfd3e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 10 by noel@chromium.org, Apr 18 2018

The error cause # 8 has been identified and fixed in http://crrev.com/551279 so we can revert #9 on trunk.

Other flake causes affecting FileManagerBrowserTest are known,  issue 829306  for example, but frame sync provider are actively working to fix that.

Comment 11 by noel@chromium.org, Apr 18 2018

.. but frame sync provider _folks_ are actively working to fix that.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194ca2e6cd90bef41d2a43269a2e6dfbf9c08dfa

commit 194ca2e6cd90bef41d2a43269a2e6dfbf9c08dfa
Author: Noel Gordon <noel@chromium.org>
Date: Wed Apr 18 12:34:54 2018

Revert "Disable flaky transfer tests which have Drive targets in FileManagerBrowserTest."

This reverts commit 978a6eb4783a8950432d57ef0d0dff862d6bfd3e.

Cause identified and fixed in http://crrev.com/551279

Tbr: fukino-san
Bug:  831211 

Original change's description:
> Disable flaky transfer tests which have Drive targets in FileManagerBrowserTest.
>
> TBR=fukino@chromium.org
>
> Bug:  831211 
> Change-Id: I173d35915b89bcd346d473d41f01db718808574c
> Reviewed-on: https://chromium-review.googlesource.com/1010829
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550384}

TBR=fukino@chromium.org,kmarshall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  831211 
Change-Id: I18de18fd85f1be7a7a1a7a2f121a6877bd3e3af5
Reviewed-on: https://chromium-review.googlesource.com/1016720
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551643}
[modify] https://crrev.com/194ca2e6cd90bef41d2a43269a2e6dfbf9c08dfa/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 13 by noel@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)

Comment 14 by noel@chromium.org, Apr 18 2018

Blockedon: 829310

Sign in to add a comment