New issue
Advanced search Search tips

Issue 831210 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Buildbucket exceeding soft memory limit

Project Member Reported by jchin...@chromium.org, Apr 10 2018

Issue description

I rolled back the version rather than reverting the CL FYI.

Comment 2 by no...@chromium.org, Apr 10 2018

the CL affects only get_builders endpoint in default service, while the OOM happens in backend. I double CL is the culprit, but there may be other CLs (e.g. in components) that affect this.

it is also possible that there is a huge swarming task that buildbucket cannot process

Comment 3 by hinoka@chromium.org, Apr 10 2018

Here's the graph of 500's in pcon:  http://shortn/_ga3EL2HtAW

Unfortunately ts_mon can't log OOMs, there's no data there.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1d74025afa51224395469d6c03e36c72292a0f36

commit 1d74025afa51224395469d6c03e36c72292a0f36
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Apr 10 20:30:52 2018

[buildbucket] limit concurrent counting queries

cr-buildbucket has 2K+ Builder entities, which results in 8K+ Datastore
counting queries. Currently they are executed at the same time and it causes
OOMs.

Limit the number of concurrent queries to 100.

R=jchinlee@chromium.org, tandrii@chromium.org

Bug:  831210 
Change-Id: Id4071af15dfbb76503e4e552dc21fa11505842fa
Reviewed-on: https://chromium-review.googlesource.com/1005727
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/1d74025afa51224395469d6c03e36c72292a0f36/appengine/cr-buildbucket/metrics.py
[modify] https://crrev.com/1d74025afa51224395469d6c03e36c72292a0f36/appengine/cr-buildbucket/test/metrics_test.py

Comment 5 by no...@chromium.org, Apr 30 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment