New issue
Advanced search Search tips

Issue 831199 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add version_codes.OREO

Project Member Reported by perezju@chromium.org, Apr 10 2018

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/56276ffc10d114be07eea05dbf1b20e9a455352c

commit 56276ffc10d114be07eea05dbf1b20e9a455352c
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Apr 27 15:08:59 2018

[devil] Add version_codes.OREO

Replaces O and O_MR1 with OREO and OREO_MR1 respectively.

O_MR1 is still defined due to external dependencies, but will also be
removed shortly.

Bug:  chromium:831199 
Change-Id: I98154daa991044da66d06777089b369cdb066043
Reviewed-on: https://chromium-review.googlesource.com/1032790
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/56276ffc10d114be07eea05dbf1b20e9a455352c/devil/devil/android/device_utils.py
[modify] https://crrev.com/56276ffc10d114be07eea05dbf1b20e9a455352c/devil/devil/android/sdk/version_codes.py
[modify] https://crrev.com/56276ffc10d114be07eea05dbf1b20e9a455352c/devil/devil/android/device_utils_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f761e681b0eb52a126dec9e072e66c048b83a9

commit 60f761e681b0eb52a126dec9e072e66c048b83a9
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 27 19:19:54 2018

Roll src/third_party/catapult/ 82069c8b6..6761f26bd (2 commits)

https://chromium.googlesource.com/catapult.git/+log/82069c8b6ea2..6761f26bd9da

$ git log 82069c8b6..6761f26bd --date=short --no-merges --format='%ad %ae %s'
2018-04-26 szager Don't default to NoopArtifactResults
2018-04-27 perezju [devil] Add version_codes.OREO

Created with:
  roll-dep src/third_party/catapult
BUG= chromium:831199 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I67d58104c1c892da7a171cc7ae67455a8899b4bc
Reviewed-on: https://chromium-review.googlesource.com/1033180
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554442}
[modify] https://crrev.com/60f761e681b0eb52a126dec9e072e66c048b83a9/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50cce18b90b688e08c7d84c64d1e11abc2521231

commit 50cce18b90b688e08c7d84c64d1e11abc2521231
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Apr 30 12:33:35 2018

[build/android] Replace version_codes.O_MR1 with OREO_MR1

Depends on:
https://chromium-review.googlesource.com/c/catapult/+/1032790

Bug:  831199 
Change-Id: If395a0a33ba5ae7cb64db11c693a43030aad1838
Reviewed-on: https://chromium-review.googlesource.com/1032748
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554728}
[modify] https://crrev.com/50cce18b90b688e08c7d84c64d1e11abc2521231/build/android/pylib/constants/__init__.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/21bd95c9099fb74f24a03e036b12cec79c274006

commit 21bd95c9099fb74f24a03e036b12cec79c274006
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Apr 30 13:49:35 2018

[devil] Remove version_codes.O_MR1

Clients should now use version_codes.OREO_MR1.

Bug:  chromium:831199 
Change-Id: I8b5f1ddc285d31adee3ff514a22191f198ede3f2
Reviewed-on: https://chromium-review.googlesource.com/1033747
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/21bd95c9099fb74f24a03e036b12cec79c274006/devil/devil/android/sdk/version_codes.py

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b6626d8147059cabb30b3aee7e529fcee13f89

commit 27b6626d8147059cabb30b3aee7e529fcee13f89
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Apr 30 17:42:35 2018

Roll src/third_party/catapult/ ad4bc36a6..21bd95c90 (1 commit)

https://chromium.googlesource.com/catapult.git/+log/ad4bc36a64cc..21bd95c9099f

$ git log ad4bc36a6..21bd95c90 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 perezju [devil] Remove version_codes.O_MR1

Created with:
  roll-dep src/third_party/catapult
BUG= chromium:831199 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia3183cda3f0fd50f1ed92297d5d503a93dc6a271
Reviewed-on: https://chromium-review.googlesource.com/1035362
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554810}
[modify] https://crrev.com/27b6626d8147059cabb30b3aee7e529fcee13f89/DEPS

Sign in to add a comment