Issue 831193 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	rsleevi@chromium.org
Closed:	Apr 2018
Cc:	mmenke@chromium.org rohitrao@chromium.org ios-bugs@chromium.org
Components:	Internals>Network>SSL
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , iOS , Chrome , Mac
Pri:	3
Type:	Task
M-68 Target-68 merge-merged-testbranch

Move SSLConfigServiceManager out of //components

Project Member Reported by rsleevi@chromium.org, Apr 10 2018

Issue description

//components/ssl_config contains a Pref-based glue for an SSLConfigService. It was moved to //components for sharing with iOS, except that iOS does not glue up the preferences to any policies - and the existing policies are device-based (the LocalState) rather than profile-based.

We can remove this component entirely, moving it up into //content.

Comment 1 by mmenke@chromium.org, Apr 10 2018

I think it be be moved into chrome/browser/net, actually?  content doesn't use it, nor does any other content embedder.

Comment 2 by rsleevi@chromium.org, Apr 10 2018

Good point. I'll move it up, and we can move it down if consumers have use for it (e.g. they want to use a CommandLinePrefStore) if they can articulate a need.

Comment 3 by rsleevi@chromium.org, Apr 10 2018

Cc: rohitrao@chromium.org
Labels: -Type-Bug OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows Type-Task

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4689ad37042515014575a4331d2977209e42624d

commit 4689ad37042515014575a4331d2977209e42624d
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Mon Apr 16 19:09:05 2018

Move SSLConfigServiceManager out of //components

SSLConfigServiceManager was moved into //components/ssl_config to
support iOS, but the only configuration is based on LocalState prefs,
which are neither set nor glued up to any device management policies.
This can all be uplifted back into //chrome.

On the //chrome side, the switches and prefs are unified back into the
general //chrome switches and prefs files, rather than being dedicated.

On the //ios side, all of the Profile-specific SSLConfig is removed, and
instead a default SSLConfig is used.

BUG= 831193 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I64908cdd17612ad2938f6bf0a3a5477dcec13122
Reviewed-on: https://chromium-review.googlesource.com/1004919
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551063}
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/about_flags.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/io_thread.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/io_thread.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store_ssl_manager_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_browsertest.cc
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager.h
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager_pref.cc
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager_pref_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/chrome_switches.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/chrome_switches.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/pref_names.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/pref_names.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/test/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/components/BUILD.gn
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/BUILD.gn
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/DEPS
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/OWNERS
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_prefs.cc
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_prefs.h
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_switches.cc
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_switches.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/test_chrome_browser_state.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/ios_chrome_io_thread_unittest.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread_unittest.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/internal/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/internal/app/application_context.cc

Comment 5 by rsleevi@chromium.org, Apr 16 2018

Labels: M-68 Target-68
Status: Verified (was: Assigned)

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4689ad37042515014575a4331d2977209e42624d

commit 4689ad37042515014575a4331d2977209e42624d
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Mon Apr 16 19:09:05 2018

Move SSLConfigServiceManager out of //components

SSLConfigServiceManager was moved into //components/ssl_config to
support iOS, but the only configuration is based on LocalState prefs,
which are neither set nor glued up to any device management policies.
This can all be uplifted back into //chrome.

On the //chrome side, the switches and prefs are unified back into the
general //chrome switches and prefs files, rather than being dedicated.

On the //ios side, all of the Profile-specific SSLConfig is removed, and
instead a default SSLConfig is used.

BUG= 831193 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I64908cdd17612ad2938f6bf0a3a5477dcec13122
Reviewed-on: https://chromium-review.googlesource.com/1004919
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551063}
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/about_flags.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/io_thread.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/io_thread.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store_ssl_manager_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_browsertest.cc
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager.h
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager_pref.cc
[rename] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/browser/ssl/ssl_config_service_manager_pref_unittest.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/chrome_switches.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/chrome_switches.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/pref_names.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/common/pref_names.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/chrome/test/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/components/BUILD.gn
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/BUILD.gn
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/DEPS
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/OWNERS
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_prefs.cc
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_prefs.h
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_switches.cc
[delete] https://crrev.com/1e7ad3a7c03a29afc26569f64e0ea99163a23fec/components/ssl_config/ssl_config_switches.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/test_chrome_browser_state.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/ios_chrome_io_thread_unittest.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread.h
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/components/io_thread/ios_io_thread_unittest.mm
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/BUILD.gn
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/internal/DEPS
[modify] https://crrev.com/4689ad37042515014575a4331d2977209e42624d/ios/web_view/internal/app/application_context.cc

►

Issue 831193 link

Issue metadata

Move SSLConfigServiceManager out of //components

Issue description

Comment 1 by mmenke@chromium.org, Apr 10 2018

Comment 1 Deleted

Comment 2 by rsleevi@chromium.org, Apr 10 2018

Comment 2 Deleted

Comment 3 by rsleevi@chromium.org, Apr 10 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Apr 16 2018

Comment 4 Deleted

Comment 5 by rsleevi@chromium.org, Apr 16 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Comment 6 Deleted

Sign in to add a comment