New issue
Advanced search Search tips

Issue 831189 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Apr 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Popup Menu: Navigate back when selecting an entry in the navigation history menu

Project Member Reported by gambard@chromium.org, Apr 10 2018 
When long pressing on the navigation history, tapping on an entry of the menu should navigate back to this page.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c7427422286c8aeb25f4590ebe17e25999ffc5b

commit 0c7427422286c8aeb25f4590ebe17e25999ffc5b
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Apr 11 13:43:36 2018

Add navigation action to popup menu

This CL adds the "navigate to page" action to the popup menu presenting
the navigation history menu.

Bug:  831189 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I04f26af28aada63278fa6530f9b8c8efaac42a30
Reviewed-on: https://chromium-review.googlesource.com/1005085
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549872}
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/cells/popup_menu_item.h
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/0c7427422286c8aeb25f4590ebe17e25999ffc5b/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm

Comment 2 by gambard@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)

Comment 3 by srikanthg@chromium.org, Apr 17 2018

Status: Verified (was: Fixed)
Popup menu works fine when tapping on the history entires.
Verified on M68.0.3398.0 canary iPhone7
►

Sign in to add a comment