Autofill - Backspace doesn't work intermittently after Autofill |
|||||||||||
Issue descriptionChrome Version: 67.0.3390.1 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to https://rsolomakhin.github.io/autofill/ (2) Enter VR Browsing (3) Play with using the buttons to enter data and autofill (4) After each action that results in text being added to a field try to place the cursor at the end and backspace over the text. Sorry the repro isn't better, can't seem to get exact repro steps yet; however in an hour's worth of playing I have seen the issue 3 times. What is the expected result? The backspace should remove characters from the field. What happens instead? The backspace doesn't remove character until you add at least one new character to the field. The attached file shows the "n" being removed but the keyboard backspace being locked. Once in this state the user can not use the backspace to remove more characters. Other keys do work and unlock the backspace.
,
Apr 10 2018
I believe you mentioned you were working on this.
,
Apr 11 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b5d70fd0787b7c44b9a089559bb6ade6aca237 commit 47b5d70fd0787b7c44b9a089559bb6ade6aca237 Author: Yash Malik <ymalik@google.com> Date: Fri Apr 13 23:26:13 2018 VR: Fix autofill related keyboard bugs Autofill exposed two keyboard input handling related bugs. 1) We weren't clearing the model capturing the web input field state after the field lost focus. As a result, upon gaining focus the second time, we were pushing the old state into the keyboard. 2) When the web input field indices change, we ask web contents for the new text around the indices. This has a side effect of "OnWebInputIndicesChanged" beinh called again. We were ignoring this second call in this case. The bug was that we weren't clearing the bit that told us to ingore, so we would fail to request the text state when we actually should have. This CL also has a functional change that clicking on the autofill suggestion doesn't hide the keyboard. Bug: 831187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I04e448addf8e30a56afe98cb32630195f3065f67 Reviewed-on: https://chromium-review.googlesource.com/1012989 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550811} [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/elements/content_element_unittest.cc [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/ui_scene_creator.cc
,
Apr 16 2018
,
Apr 16 2018
Verified that on build 67.0.3396.3 Canary that I was unable to repro the issue after 10+ minutes of trying . Since there are no specific repro steps I can only assume this is fixed now.
,
Apr 16 2018
It seems that due to the intermittent nature of this bug the previous verification was done against a build without the fix. Need to reverify on build 68.0.3397.0+.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b5d70fd0787b7c44b9a089559bb6ade6aca237 commit 47b5d70fd0787b7c44b9a089559bb6ade6aca237 Author: Yash Malik <ymalik@google.com> Date: Fri Apr 13 23:26:13 2018 VR: Fix autofill related keyboard bugs Autofill exposed two keyboard input handling related bugs. 1) We weren't clearing the model capturing the web input field state after the field lost focus. As a result, upon gaining focus the second time, we were pushing the old state into the keyboard. 2) When the web input field indices change, we ask web contents for the new text around the indices. This has a side effect of "OnWebInputIndicesChanged" beinh called again. We were ignoring this second call in this case. The bug was that we weren't clearing the bit that told us to ingore, so we would fail to request the text state when we actually should have. This CL also has a functional change that clicking on the autofill suggestion doesn't hide the keyboard. Bug: 831187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I04e448addf8e30a56afe98cb32630195f3065f67 Reviewed-on: https://chromium-review.googlesource.com/1012989 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550811} [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/elements/content_element_unittest.cc [modify] https://crrev.com/47b5d70fd0787b7c44b9a089559bb6ade6aca237/chrome/browser/vr/ui_scene_creator.cc
,
Apr 20 2018
Just tried to verify this on Canary build 68.0.3400.0. It is intermittent but I was able to trigger it a few different times in about 10 minutes of playing. Reactivating the bug.
,
Apr 24 2018
,
May 1 2018
,
May 3 2018
I have played with Dev, Beta, and Canary builds to repro this issue and have been unable to repro as stated or by just playing with the Autofill. There have been changes to Autofill which probably either fixed or masked this issue now. At this point I am resolving as Won't Fix (aka Not Repro). If we see it again we can either reactivate this bug or file a new one. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ymalik@chromium.org
, Apr 10 2018