publish_tarball: Non-fatal failures in versions prior to the great Blink mv |
|||||||
Issue descriptionSee https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/10503. It's green, but some steps trying to prune third_party/blink/manual_tests and third_party/blink/perf_tests are red because those directories do not exist in version 67.0.3393.0 (which still has them in third_party/WebKit/ManualTests and third_party/WebKit/PerformanceTests). The new directories were added in https://chromium-review.googlesource.com/1004092 These failures are not fatal (see https://chromium.googlesource.com/infra/infra.git/+/89d54a3c996993b8b7e004e7906e1b5d41f82a9f/recipes/recipes/publish_tarball.py#124), but people who subscribe to failures in the bot (such as myself) will get spammed for every new build, as they will either have third_party/WebKit/{Manual,Performance}Tests or third_party/blink/{manual,perf}_tests but not both and thus no builds will ever pass with no red steps. Fixing this is easy, but I'm filing a bug to decide on which action to take: we can just skip directories that do not exist (at the risk of accumulating a list of non-existent directories there), add some directories based on the version we're trying to build or try to make those errors non-red (and decide how vocal we want to be about it).
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/23ad18f071a1b7c2a2804920c27f601b4ec8fb25 commit 23ad18f071a1b7c2a2804920c27f601b4ec8fb25 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Apr 10 19:55:42 2018 publish_tarball: Use correct paths across the great blink mv R=mmoss BUG= 831165 Change-Id: Ifdb40cee9272f70319a45d2494f18452fa2b2d1c Reviewed-on: https://chromium-review.googlesource.com/1005794 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> [modify] https://crrev.com/23ad18f071a1b7c2a2804920c27f601b4ec8fb25/recipes/README.recipes.md [modify] https://crrev.com/23ad18f071a1b7c2a2804920c27f601b4ec8fb25/recipes/recipes/publish_tarball.py [modify] https://crrev.com/23ad18f071a1b7c2a2804920c27f601b4ec8fb25/recipes/recipes/publish_tarball.expected/basic.json
,
Apr 10 2018
,
Apr 11 2018
Reopening: https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/10511 67.0.3392.0 doesn't contain third_party/blink/{perf,manual}_tests. In fact, these directories haven't been moved from third_party/WebKit at all yet. If we're to do version checks in publish_tarball.py, we'll need to do it in tandem with tkent's work in bug 829695 . I'll try to revert your CL to prevent further -lite tarballs from including LayoutTests and PerformanceTests in the meantime.
,
Apr 11 2018
,
Apr 11 2018
I don't think we can move ManualTests and PerformanceTests soon. Does it help to add almost-empty third_party/blink/{manual,perf}_tests now?
,
Apr 11 2018
I don't think it helps much, as we'd then either need to purge both third_party/WebKit and third_party/blink for a certain range of versions or continue to ignore third_party/blink until the actual move happens. If we choose to keep the version-based approach we've adopted in thomasanderson's CL the best would be to just revert your original CL and only care about third_party/WebKit for the time being.
,
Apr 11 2018
Reverting both CLs sgtm
,
Apr 12 2018
I'm sorry, we have just moved WebKit/ManualTests to blink/manual_tests. So revering won' work. How about this CL? https://chromium-review.googlesource.com/c/infra/infra/+/1008945 Anyway, publish_tarball looks a bad design. It strongly depends on chromium's main repository structure. A long-term fix would be to add src/build/tarball_blocklist.txt to Chromium repo, and publish_tarball refers to it.
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5f2afb8b8822bf6d1b9d1de6ec44577bc6185616 commit 5f2afb8b8822bf6d1b9d1de6ec44577bc6185616 Author: Kent Tamura <tkent@chromium.org> Date: Fri Apr 13 21:59:45 2018 publish_tarball: Prune Blink test directories only if it exists. Bug: 831165 Change-Id: Ia04a82bcbe11bfd1fc6c60f66347f5a3e3926925 Reviewed-on: https://chromium-review.googlesource.com/1008945 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/5f2afb8b8822bf6d1b9d1de6ec44577bc6185616/recipes/README.recipes.md [modify] https://crrev.com/5f2afb8b8822bf6d1b9d1de6ec44577bc6185616/recipes/recipes/publish_tarball.py [modify] https://crrev.com/5f2afb8b8822bf6d1b9d1de6ec44577bc6185616/recipes/recipes/publish_tarball.expected/basic.json
,
Apr 16 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by thomasanderson@chromium.org
, Apr 10 2018Status: Started (was: Available)