New issue
Advanced search Search tips

Issue 831146 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Undefined-shift in FcCharSetHasChar

Project Member Reported by ClusterFuzz, Apr 10 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5693109049229312

Fuzzer: libFuzzer_renderer_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  FcCharSetHasChar
  gfx::CachedFont::HasGlyphForCharacter
  gfx::CachedFontSet::GetFallbackFontForChar
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=525942:525946

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693109049229312

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 10 2018

Components: UI>GFX
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 10 2018

Labels: Test-Predator-Auto-Owner
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/56ddd0320acc76ba78ff650852b77a8ff8981617 ([mojo-loading] Remove ChromeIPC code).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: thomasanderson@chromium.org yhirano@chromium.org
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
I think 4f1a60552748d150783655ee6f7b6f7084e3af95 is more likely related.
Owner: thomasanderson@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83dadc4b72638cdcdaefc63d3663e9849e2b8a26

commit 83dadc4b72638cdcdaefc63d3663e9849e2b8a26
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jun 08 02:27:28 2018

Update fontconfig

Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
and [4] to fix a bug and clean up some log spam.

Fontconfig also now requires libuuid as a dependency, so whitelist it as a
dependency since we statically link fontconfig.

[1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..7ad010e80bdf8e41303e322882ece908f5e04c74
[2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
[3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
[4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74

BUG= 831146 

Change-Id: I5b9ae95e4b0ab03735a9adc5582eabeb45241ce8
Reviewed-on: https://chromium-review.googlesource.com/1009071
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565514}
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/DEPS
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/OWNERS
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/README.chromium
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/config.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/83dadc4b72638cdcdaefc63d3663e9849e2b8a26/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70abb1e42279836da0dfcd63595fd2f4a744edd

commit c70abb1e42279836da0dfcd63595fd2f4a744edd
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jun 08 04:40:15 2018

Revert "Update fontconfig"

This reverts commit 83dadc4b72638cdcdaefc63d3663e9849e2b8a26.

Reason for revert: Broke Linux CFI bot

https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8420

Original change's description:
> Update fontconfig
> 
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> and [4] to fix a bug and clean up some log spam.
> 
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
> 
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..7ad010e80bdf8e41303e322882ece908f5e04c74
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> 
> BUG= 831146 
> 
> Change-Id: I5b9ae95e4b0ab03735a9adc5582eabeb45241ce8
> Reviewed-on: https://chromium-review.googlesource.com/1009071
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565514}

TBR=thestig@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org

Change-Id: Ieffcdeaeea22e5617adeac593d3df1127e3d1062
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831146 
Reviewed-on: https://chromium-review.googlesource.com/1091478
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565530}
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/DEPS
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/OWNERS
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/README.chromium
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/config.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/c70abb1e42279836da0dfcd63595fd2f4a744edd/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6db40d91d0bd2afeb39f78f6d22404c3525b63c

commit e6db40d91d0bd2afeb39f78f6d22404c3525b63c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jun 14 22:32:23 2018

Update fontconfig to 6cc99d6a

Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
[4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
fix a use-after-free.

Fontconfig also now requires libuuid as a dependency, so whitelist it as a
dependency since we statically link fontconfig.

[1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
[2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
[3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
[4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
[5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
[6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde

BUG= 831146 ,822737, 787020 , 829890 ,847323
TBR=thestig,dnicoara

Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
Reviewed-on: https://chromium-review.googlesource.com/1095538
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567445}
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/DEPS
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/OWNERS
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/README.chromium
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/config.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e

commit f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Jun 14 23:21:47 2018

Revert "Update fontconfig to 6cc99d6a"

This reverts commit e6db40d91d0bd2afeb39f78f6d22404c3525b63c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 567445 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZGI0MGQ5MWQwYmQyYWZlYjM5Zjc4ZjZkMjI0MDRjMzUyNWI2M2MM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/83483

Sample Failed Step: compile

Original change's description:
> Update fontconfig to 6cc99d6a
> 
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
> 
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
> 
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> 
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
> 
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 831146 ,822737, 787020 , 829890 ,847323

Change-Id: I47d475941350efc76370fa5eb5043c80c5063495
Reviewed-on: https://chromium-review.googlesource.com/1101759
Cr-Commit-Position: refs/heads/master@{#567472}
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/DEPS
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/OWNERS
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/README.chromium
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/config.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c91664fce2e753a65b04107ad24c7422691cf9d

commit 0c91664fce2e753a65b04107ad24c7422691cf9d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 18 23:13:53 2018

Reland "Update fontconfig to 6cc99d6a"

This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c

Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).

Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

TBR=thestig,dnicoara

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
Reviewed-on: https://chromium-review.googlesource.com/1104759
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568221}
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/DEPS
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/OWNERS
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/README.chromium
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/config.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812edd08bc908333c1c10205cbc5f52ef33c7dec

commit 812edd08bc908333c1c10205cbc5f52ef33c7dec
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Jun 19 05:03:31 2018

Revert "Reland "Update fontconfig to 6cc99d6a""

This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.

Reason for revert: Broke Linux Builder (dbg)(32)

Still missing libuuid:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697

[775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
FAILED: v8_context_snapshot.bin 
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
./v8_context_snapshot_generator failed with exit code 127

Original change's description:
> Reland "Update fontconfig to 6cc99d6a"
> 
> This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> 
> Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> 
> Original change's description:
> > Update fontconfig to 6cc99d6a
> >
> > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > fix a use-after-free.
> >
> > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > dependency since we statically link fontconfig.
> >
> > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> >
> > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > TBR=thestig,dnicoara
> >
> > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567445}
> 
> TBR=thestig,dnicoara
> 
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> Reviewed-on: https://chromium-review.googlesource.com/1104759
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568221}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org

Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Reviewed-on: https://chromium-review.googlesource.com/1105539
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568346}
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/DEPS
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/OWNERS
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/README.chromium
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/config.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c1584a2fade0146b7cd3380abe42feda02ad7c

commit a0c1584a2fade0146b7cd3380abe42feda02ad7c
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Jun 22 22:01:06 2018

Reland "Reland "Update fontconfig to 6cc99d6a""

This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec.

Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 )

Original change's description:
> Revert "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.
> 
> Reason for revert: Broke Linux Builder (dbg)(32)
> 
> Still missing libuuid:
> 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> 
> [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> FAILED: v8_context_snapshot.bin 
> python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> ./v8_context_snapshot_generator failed with exit code 127
> 
> Original change's description:
> > Reland "Update fontconfig to 6cc99d6a"
> > 
> > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> > 
> > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> > 
> > Original change's description:
> > > Update fontconfig to 6cc99d6a
> > >
> > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > fix a use-after-free.
> > >
> > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > dependency since we statically link fontconfig.
> > >
> > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > >
> > > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > > TBR=thestig,dnicoara
> > >
> > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#567445}
> > 
> > TBR=thestig,dnicoara
> > 
> > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568221}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> 
> Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Reviewed-on: https://chromium-review.googlesource.com/1105539
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568346}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
Reviewed-on: https://chromium-review.googlesource.com/1112179
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569800}
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/DEPS
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/OWNERS
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/README.chromium
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/config.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 12 by ClusterFuzz, Jun 24 2018

ClusterFuzz has detected this issue as fixed in range 569798:569803.

Detailed report: https://clusterfuzz.com/testcase?key=5693109049229312

Fuzzer: libFuzzer_renderer_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  FcCharSetHasChar
  gfx::CachedFont::HasGlyphForCharacter
  gfx::CachedFontSet::GetFallbackFontForChar
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=524386:524393
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=569798:569803

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693109049229312

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jun 24 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5693109049229312 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee206c596acea3c453ec646c6002972793dbe62e

commit ee206c596acea3c453ec646c6002972793dbe62e
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Jun 25 18:34:05 2018

Revert "Reland "Reland "Update fontconfig to 6cc99d6a"""

This reverts commit a0c1584a2fade0146b7cd3380abe42feda02ad7c.

Reason for revert: It broken Chrome PFQ, see  crbug.com/856142  for more details.

Original change's description:
> Reland "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec.
> 
> Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 )
> 
> Original change's description:
> > Revert "Reland "Update fontconfig to 6cc99d6a""
> > 
> > This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.
> > 
> > Reason for revert: Broke Linux Builder (dbg)(32)
> > 
> > Still missing libuuid:
> > 
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> > 
> > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> > FAILED: v8_context_snapshot.bin 
> > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> > ./v8_context_snapshot_generator failed with exit code 127
> > 
> > Original change's description:
> > > Reland "Update fontconfig to 6cc99d6a"
> > > 
> > > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> > > 
> > > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> > > 
> > > Original change's description:
> > > > Update fontconfig to 6cc99d6a
> > > >
> > > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > > fix a use-after-free.
> > > >
> > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > > dependency since we statically link fontconfig.
> > > >
> > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > >
> > > > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > > > TBR=thestig,dnicoara
> > > >
> > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#567445}
> > > 
> > > TBR=thestig,dnicoara
> > > 
> > > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#568221}
> > 
> > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> > 
> > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > Reviewed-on: https://chromium-review.googlesource.com/1105539
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568346}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
> Reviewed-on: https://chromium-review.googlesource.com/1112179
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Elliott Friedman <friedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569800}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,friedman@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: Ic4c518680efb4480a9568829996f5ceebaf459e7
Reviewed-on: https://chromium-review.googlesource.com/1113840
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570103}
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/DEPS
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/OWNERS
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/README.chromium
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/config.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81162e7432ecf59a861e5ba7be9f28b28b891dea

commit 81162e7432ecf59a861e5ba7be9f28b28b891dea
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 25 22:44:09 2018

"Reland "Update fontconfig to 6cc99d6a"

Reason for reland: this CL includes a fallback for when the tests are run in an
installed environment.  Hopefully this should be sufficient to fix the CrOs bot
breakage.

Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

TBR=thestig@chromium.org,dnicoara@chromium.org

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 ,  856142 
Change-Id: I74037fc1e7719ab61e6a5aff52ced8845482273b
Reviewed-on: https://chromium-review.googlesource.com/1114078
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570210}
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/DEPS
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/OWNERS
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/README.chromium
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/config.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcstdint.h

Sign in to add a comment