CrOS "depot_tools" checkout should initialize CIPD binaries. |
|||
Issue descriptionFollow-up from crbug.com/830646 . Users who wish to use "depot_tools" binary utilities need to initialize their CIPD binaries. This is done indirectly for users when they run "gclient", or can be done explicitly by running the "update_depot_tools" script: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/update_depot_tools It would be a good idea for "repo" checkouts (notably, user "repo" checkouts) of "depot_tools" to perform this initialization so the binary tools are available for them. In this case, the supported way to download LogDog logs is with the "cit logdog" tool. This is a CIPD binary that is only present when initialization runs. NOTE: "update_depot_tools" mutates the "depot_tools" checkout, adding some binaries to some dotfile directories. In cases where immutability is critical (e.g., Gentoo builds), it should probably be avoided.
,
Apr 25 2018
Does it also update the version of depot_tools?
,
Apr 26 2018
Update can be disabled via environment variable: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/#updating Or permanently via a flag file: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/update_depot_tools_toggle.py You would have "repo" do one of these!
,
May 9 2018
This is the recommended way of setting up depot_tools: http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up I don't think repo should be responsible for this.
,
May 11 2018
which particular step of the recommended way makes sure that the binaries are available? Does chrome os setup process need to change?
,
May 12 2018
Probably the gclient sync step? In any case, users should be using a separate depot_tools checkout for normal use and use the canonical depot_tools docs. I don't think we should add the special behavior described in the initial post to repo. However, reading the upstream bug, I don't think that's what is actually being requested. It sounds like we just want to make repo call update_depot_tools like gclient does currently. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jrbarnette@chromium.org
, Apr 11 2018