New issue
Advanced search Search tips

Issue 831113 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Remove experimental flags

Project Member Reported by gambard@chromium.org, Apr 10 2018

Issue description

The experimental flags for different search icons or button layout should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2057ccb45949f19bb5317a07fd1024c5f1c8d7a6

commit 2057ccb45949f19bb5317a07fd1024c5f1c8d7a6
Author: Gauthier Ambard <gambard@google.com>
Date: Wed Apr 11 08:57:52 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d06d1b93820292e5ff41e4367f37d1d296a2244a

commit d06d1b93820292e5ff41e4367f37d1d296a2244a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Apr 11 11:47:58 2018

Remove toolbar's experiments flags

This CL removes the experimental flags and associated code, added to
experiment with different toolbar layout of search icons.

Bug:  831113 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9a1cbcce2a1536773394c98a5bf31bb6bf2e127f
Reviewed-on: https://chromium-review.googlesource.com/1006578
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549858}
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/providers/images/chromium_branded_image_provider.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/providers/images/chromium_branded_image_provider.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_visibility_configuration.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_visibility_configuration.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/clean/toolbar_consumer.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator_unittest.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.mm
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/public/provider/chrome/browser/images/branded_image_provider.h
[modify] https://crrev.com/d06d1b93820292e5ff41e4367f37d1d296a2244a/ios/public/provider/chrome/browser/images/branded_image_provider.mm

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9e50b94f39205ff0a47280757acebae621d92a0c

commit 9e50b94f39205ff0a47280757acebae621d92a0c
Author: Gauthier Ambard <gambard@google.com>
Date: Wed Apr 18 13:42:38 2018

NextAction: 2018-04-25
The NextAction date has arrived: 2018-04-25

Comment 7 by cma...@chromium.org, Apr 25 2018

NextAction: ----

Sign in to add a comment