Issue 831106 link

Starred by 1 user

Issue metadata

Status:	Duplicate
Merged:	issue 830255
Owner:	----
Closed:	Apr 2018
Cc:	jbroman@chromium.org dcheng@chromium.org lfg@chromium.org
Components:	Blink>Bindings
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Generated Blink bindings don't use full #include paths

Project Member Reported by pwnall@chromium.org, Apr 10 2018

Issue description

Examples: https://cs.chromium.org/search/?q="bindings/core/v8/generated_code_helper.h"+file:out/Debug/gen

Likely list of all hard-coded #include paths: https://cs.chromium.org/search/?q=file:third_party/blink/renderer/bindings/scripts+"INCLUDES+%3D+frozenset"+case:yes

Comment 1 by pwnall@chromium.org, Apr 10 2018

I ran into this issue because of a nacl build breakage:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_nacl_sdk/918
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_nacl_sdk%2F918%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Comment 2 by raphael....@intel.com, Apr 10 2018

This looks more like bug 830963 than an issue with relative vs absolute paths.

Comment 3 by thakis@chromium.org, Apr 10 2018

Mergedinto: 830963
Status: Duplicate (was: Untriaged)

Comment 4 by peria@chromium.org, May 3 2018

Mergedinto: -830963 830255

►

Issue 831106 link

Issue metadata

Generated Blink bindings don't use full #include paths

Issue description

Comment 1 by pwnall@chromium.org, Apr 10 2018

Comment 1 Deleted

Comment 2 by raphael....@intel.com, Apr 10 2018

Comment 2 Deleted

Comment 3 by thakis@chromium.org, Apr 10 2018

Comment 3 Deleted

Comment 4 by peria@chromium.org, May 3 2018

Comment 4 Deleted

Sign in to add a comment