New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: No default focus is seen anywhere on the page neither on 'More/skip'button in Google play apps and services screen

Project Member Reported by rkalavakuntla@chromium.org, Apr 10 2018

Issue description

Chrome Version:67.0.3390.0/10562.0.0 dev channel Reks
OS: Chrome OS ARC

What steps will reproduce the problem?
(1)Recover Build>>Sign into user >>go to Playstore window which is seen after You'Re signed in! screen
(2)In Google play Apps and services screen>>hit Enter and observe

Actual:No default focus is seen anywhere on the page neither on 'More/skip'button and no action is performed on hitting Enter key.
Expected:Default focus should be seen on the Playstore window on 'More/skip' button

Raising this as Non-Regression since the new Play store UI is seen from 67.0.3390.0 dev

Note:
1.Issue is not seen in Linux,Windows OS
2.Issue is not seen when Playstore window is opened in Sign-in user


Attached the screencast for reference..


 
Actual.jpg
2.5 MB View Download
Expected.jpg
5.9 MB View Download

Comment 1 by khmel@chromium.org, Apr 11 2018

Owner: lgcheng@google.com
Hi Long, could you please take a look?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d6cb59197052cca2349b982db957ffe12e0b1b

commit 54d6cb59197052cca2349b982db957ffe12e0b1b
Author: lgcheng <lgcheng@google.com>
Date: Thu Apr 12 23:46:45 2018

Fix button focus issue.

Since ArcTos page can be loaded before it's shown, focus status is not
correctly set in the case. Try to set the focus status of default
button when the page is shown.

Bug:  831104 
Test: Manual.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b62ee8a45de1bfa69152f1b7813918185aaa276
Reviewed-on: https://chromium-review.googlesource.com/1011225
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550415}
[modify] https://crrev.com/54d6cb59197052cca2349b982db957ffe12e0b1b/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js

Comment 3 by lgcheng@google.com, Apr 12 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d6cb59197052cca2349b982db957ffe12e0b1b

commit 54d6cb59197052cca2349b982db957ffe12e0b1b
Author: lgcheng <lgcheng@google.com>
Date: Thu Apr 12 23:46:45 2018

Fix button focus issue.

Since ArcTos page can be loaded before it's shown, focus status is not
correctly set in the case. Try to set the focus status of default
button when the page is shown.

Bug:  831104 
Test: Manual.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b62ee8a45de1bfa69152f1b7813918185aaa276
Reviewed-on: https://chromium-review.googlesource.com/1011225
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550415}
[modify] https://crrev.com/54d6cb59197052cca2349b982db957ffe12e0b1b/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js

Sign in to add a comment