Implement ext4 migration banner on views-based login screen. |
||||
Issue descriptionWe need to implement the ext4 migration banner, whose visual design is updated recently. This issue is created from a comment in https://chromium-review.googlesource.com/c/chromium/src/+/1003014/ Note that views-based login is coming up and we need to implement the banner there too. You might want to touch based with Jacob on that. I imagine it could be a LoginBubble similar to the |tooltip_bubble_| in LockContentsView. [1] [1] https://cs.chromium.org/chromium/src/ash/login/ui/lock_contents_view.cc?rcl=138363ffd7c05f6152572cfc7e0869ff4484d743&l=458
,
May 22 2018
,
Aug 1
,
Aug 1
fukino@ will you have time to address this in m70?
,
Aug 1
Yes, I've just sent out a CL for this issue.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a14cbc00d5c314c5ea3dae64b4006258daa929 commit 00a14cbc00d5c314c5ea3dae64b4006258daa929 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Aug 08 05:27:22 2018 Show ext4 migration banner as LoginBubble on view-based login screen. The ext4 migration banner should be shown as a persistent warning message below the focused user's password field. LoginBubble is used to implement the message. Since only the ext4 migration warning uses UserBoardView::ShowBannerMessage(), I named the new mojo API as ShowWarningBanner() instead of ShowBannerMessage() and omitted |is_warning| parameter from the API. Bug: 831099 Test: ash_unittests, manual test using Kevin with profiles on old encryptions. Change-Id: I01838860bc9bd36fae69cdc869ad6837c7d2717c Reviewed-on: https://chromium-review.googlesource.com/1158672 Reviewed-by: Martin Barbella <mbarbella@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#581480} [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/login_screen_controller.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/login_screen_controller.h [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/login_data_dispatcher.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/login/ui/login_data_dispatcher.h [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/chrome/browser/chromeos/login/user_board_view_mojo.cc [modify] https://crrev.com/00a14cbc00d5c314c5ea3dae64b4006258daa929/chrome/browser/chromeos/login/user_board_view_mojo.h
,
Aug 8
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jdufault@chromium.org
, May 7 2018