Opening dialog to select multiple files does not set initial folder On Windows. |
|||||
Issue descriptionChrome Version : 65.0.3325.181 When a dialog is opened to select multiple files to upload, the initial folder is not set. This seems to be because SelectFileDialogImpl::RunOpenMultiFileDialog in select_file_dialog_win.cc does not have an argument to receive initial folder, and hence when ExecuteSelectFile calls it, the default_path is ignored.
,
Apr 10 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04497dc594b83c7f660c95e001e09fabbb319ac1 commit 04497dc594b83c7f660c95e001e09fabbb319ac1 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Apr 11 07:16:02 2018 Set initial path for Windows multi-file open. The initial path is set for SelectFileDialogImpl::RunOpenMultiFileDialog. Bug: 831097 Change-Id: I0de503f148efc8cda2677c907e78b8da6ce09101 Reviewed-on: https://chromium-review.googlesource.com/1005079 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549806} [modify] https://crrev.com/04497dc594b83c7f660c95e001e09fabbb319ac1/ui/shell_dialogs/select_file_dialog_win.cc
,
Apr 11 2018
,
Apr 12 2018
Tried checking the issue on reported chrome version 65.0.3325.181 and on the latest canary 67.0.3395.0 using windows 10 with the below mentioned steps. 1. Launched chrome 2. Navigated to https://encodable.com/uploaddemo/ 3. Clicked on choose file 4. Selected 3 files -> open We observed similar behaviour in both the above mentioned versions. @Ramin Halavati: As we are not very clear about the expected and actual behaviour, Could you please help us in verifying the fix. It would be highly helpful if shared with a test URL to confirm the fix. Thanks!
,
Apr 12 2018
Hi, Please follow these steps: 1. Launch chrome 2. Navigate to https://encodable.com/uploaddemo/ 3. Click on choose file. 4. Select files from folder X -> open. 5. Open an incognito Window. 6. Navigate to https://encodable.com/uploaddemo/ 7. Click on choose file. 8. Select files from folder Y -> open. 9. Close incognito Window. 10. In the regular window that you were before, click on choose file. 11. The open dialog should be in folder X, but it is in Y. This happens because when you opened the dialog in incognito window, it switched current directory from X to Y. When you go back to regular window, you still expect to be in directory X, but due to this bug, current directory is not changed back to X.
,
Apr 13 2018
Verified the fix on Windows-10 using Chrome version #67.0.3396.0 as per the comment #6. Attaching screen cast for reference. Observed that the open dialogue is in first selected folder, but not in the folder which is selected in incognito mode. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 65.0.3325.181 @Ramin Halavati: Comment#6 was very helpful in verifying the fix. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rhalavati@chromium.org
, Apr 10 2018Status: Started (was: Unconfirmed)
Summary: Opening dialog to select multiple files does not set initial folder On Windows. (was: Opening dialog to select multiple files does not set initial folder.)