New issue
Advanced search Search tips

Issue 831088 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

5.1 audio not working on some USB audio devices

Project Member Reported by louiscollard@chromium.org, Apr 10 2018

Issue description

Some USB devices with multiple channels are not working properly with cras, which is downmixing audio to stereo. 

After some investigation, it seems that this is because cras cannot find a channel map that matches the stream.

With at least the C-Media CM106 device I have to test with (which supports 8 channels), the 6-channel output map provided by the device includes SND_CHMAP_SL SND_CHMAP_SR channels, rather than _RL and _RR, which is what the stream is providing.

cras is designed to deal with situations like this, and appears to be able to map the other way round (when the stream contains SL/SR, and the device exposes RL and RR), but does not map in this direction (from RL/RR to SL/SR).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/26289ebbb193fb7cf13401cefce5b934e2eb1eab

commit 26289ebbb193fb7cf13401cefce5b934e2eb1eab
Author: Louis Collard <louiscollard@chromium.org>
Date: Thu Apr 12 03:28:04 2018

CRAS: audio_format - Support mapping RL and RR channels to SL and SR.

Currently, a stream with SL and SR channels can play on a device with
RL and RR channels (but no SL/SR channels) - and the streams will be
mapped accordingly. The inverse (a stream with RL/RR playing to a
device with SL/SR) is not possible. This change enables that inverse
mapping.

BUG= chromium:831088 
TEST=Ran locally on eve

Change-Id: I7613249e937af760449d0f4699de47d2f6cbe804
Reviewed-on: https://chromium-review.googlesource.com/1004814
Commit-Ready: Louis Collard <louiscollard@chromium.org>
Tested-by: Louis Collard <louiscollard@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/26289ebbb193fb7cf13401cefce5b934e2eb1eab/cras/src/common/cras_audio_format.c

Status: Fixed (was: Started)

Sign in to add a comment