New issue
Advanced search Search tips

Issue 831078 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 417518



Sign in to add a comment

TIMEOUT site_per_process_interactive_ui_tests on Linux dbg: ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage

Project Member Reported by shimazu@chromium.org, Apr 10 2018

Issue description

ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage is continuously timing out on Linux Tests (dbg) bot.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_interactive_ui_tests&tests=ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage

I'll tentatively disable the test on Linux dbg, but it probably needs another filter for site-per-process tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c768dee98673530795908defa9ede5c918ea637a

commit c768dee98673530795908defa9ede5c918ea637a
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Apr 10 09:14:59 2018

Disable a test in ExtensionCrashRecoveryTest on Linux dbg

TBR=rdevlin.cronin@chromium.org
NOTRY=true

Bug: 831078
Change-Id: Id97988d690315e7d2734a11255dcc9ba901c3d78
Reviewed-on: https://chromium-review.googlesource.com/1004560
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549464}
[modify] https://crrev.com/c768dee98673530795908defa9ede5c918ea637a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Cc: -rdevlin....@chromium.org
Labels: -Sheriff-Chromium OS-Linux
Owner: rdevlin....@chromium.org
Status: Assigned (was: Available)
Remove Sheriff-Chromium since it's now disabled. Let me keep this issue as P1 since the test has been disabled all Linux dbg cases. 
Let me assign this to Delvin, who are the owner of the test. Feel free to triage this.
Blocking: 417518
Components: Internals>Sandbox>SiteIsolation
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd

commit fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Sat Apr 21 14:55:20 2018

Make --site-per-process the default on ToT via fieldtrial_testing_config

Note that features::kSitePerProcess is a //chrome-layer feature.
Therefore, after this CL:
- site-per-process is turned-on by default in //chrome layer and above
  (i.e. in code that uses ChromeContentBrowserClient).
- site-per-process stays off by default in //content layer

Also note that fieldtrial_testing_config.json only affects how default
Chromium tests are run, but doesn't affect the default behavior of
Chrome builds shipped to end-users - these will continue to have
site-per-process off by default (and controlled via field trials).

In addition to making site-per-process the default, the CL makes the
following supplementary changes:
- site_per_process_browser_tests test step is removed and replaced
  by not_site_per_process_browser_tests (similarily for a few other
  //chrome-layer test suites where I've verified that
  content::AreAllSitesIsolatedForTesting returns true after this CL).
- A few last-minute changes to disable tests that fail with
  --site-per-process - these changes are limited to site-per-process
  and/or specific platforms.

Bug:  824966 , 831078,  833423 , 833429, 833430
Change-Id: Ie87e48658864203d33d1ae647fb2d98a7c488765
Tbr: zhenw@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/981019
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552589}
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/policy/site_isolation_policy_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/content/public/browser/site_isolation_policy.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment