New issue
Advanced search Search tips

Issue 831076 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

new Request('/', {body: {}}) should throw

Project Member Reported by yhirano@chromium.org, Apr 10 2018

Issue description

But currently blink creates a Request with null body.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f68472983dc3802dc4e40958ebd16a7e51ee84

commit 03f68472983dc3802dc4e40958ebd16a7e51ee84
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Apr 13 05:07:27 2018

Stringify RequestInit.body

As specified, RequestInit.body should be stringified, i.e.,
{toString(): () => 'hi!'} should be treated as same as 'hi!'.

Bug:  831076 
Change-Id: I4118c0faa9535d62b3db2529bf23716fdc25a997
Reviewed-on: https://chromium-review.googlesource.com/1004561
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550523}
[modify] https://crrev.com/03f68472983dc3802dc4e40958ebd16a7e51ee84/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-002.html
[modify] https://crrev.com/03f68472983dc3802dc4e40958ebd16a7e51ee84/third_party/blink/renderer/core/fetch/request_init.cc

Labels: Hotlist-Interop
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f68472983dc3802dc4e40958ebd16a7e51ee84

commit 03f68472983dc3802dc4e40958ebd16a7e51ee84
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Apr 13 05:07:27 2018

Stringify RequestInit.body

As specified, RequestInit.body should be stringified, i.e.,
{toString(): () => 'hi!'} should be treated as same as 'hi!'.

Bug:  831076 
Change-Id: I4118c0faa9535d62b3db2529bf23716fdc25a997
Reviewed-on: https://chromium-review.googlesource.com/1004561
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550523}
[modify] https://crrev.com/03f68472983dc3802dc4e40958ebd16a7e51ee84/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-002.html
[modify] https://crrev.com/03f68472983dc3802dc4e40958ebd16a7e51ee84/third_party/blink/renderer/core/fetch/request_init.cc

Sign in to add a comment