New issue
Advanced search Search tips

Issue 831073 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jul 19
Cc:
clamy@chromium.org
benmason@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 848123



Sign in to add a comment

If a same-origin download is redirected to another origin, treat it as a navigation

Project Member Reported by jochen@chromium.org, Apr 10 2018 
right now, we treat cross origin downloads as navigations. We should do the same if a same origin download gets (server) redirected to a cross origin URL
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7678c8ace3a3a31cb49225afd9200b72fe22b7aa

commit 7678c8ace3a3a31cb49225afd9200b72fe22b7aa
Author: Jochen Eisinger <jochen@chromium.org>
Date: Mon May 07 15:47:34 2018

Remove suggested filename plumbing

The codepath is no longer used, instead, we just navigate to cross
origin URLs.

BUG= 831073 , 823639 , 660288 

Change-Id: I6a347a11e84539ad73d2b0b6aaaa1cc97d0b6118
Reviewed-on: https://chromium-review.googlesource.com/1016906
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556455}
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/download/download_ui_controller.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/extensions/extension_view_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/android/external_protocol_dialog_android.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/test/data/extensions/api_test/webnavigation/download/test_download.js
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/resource_downloader.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/public/common/in_progress_download_manager.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/intercept_navigation_throttle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params_android.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_request_core.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/blocked_scheme_navigation_throttle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_proxy_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_loader_util.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_loader_util.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/frame_messages.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/navigation_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/navigation_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_controller.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_handle.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/page_navigator.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/test/render_view_test.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/shell/browser/shell.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/extensions/browser/extension_navigation_throttle.cc
[delete] https://crrev.com/72aef1a4cea800fff0d5375c284c6d071cf3d46c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt
[delete] https://crrev.com/72aef1a4cea800fff0d5375c284c6d071cf3d46c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/third_party/blink/renderer/core/loader/frame_loader.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdc12d12044b67d79ae1ace0eb21725405cfafdd

commit cdc12d12044b67d79ae1ace0eb21725405cfafdd
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue May 08 15:07:47 2018

Plumb is_download to devtools when using network service

BUG= 831073 
R=jam@chromium.org

Change-Id: I100991624e40de2c947f09cd9034e63d180a5695
Reviewed-on: https://chromium-review.googlesource.com/1049386
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556801}
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cdc12d12044b67d79ae1ace0eb21725405cfafdd/content/browser/loader/navigation_url_loader_network_service.cc

Comment 4 by palmer@chromium.org, Jun 5 2018

Blocking: 848123

Comment 5 by palmer@chromium.org, Jun 5 2018

Labels: -Pri-2 M-68 OS-Fuchsia Pri-1
Summary: If a same-origin download is redirected to another origin, treat it as a navigation (was: if a same origin download is redirect cross origin, treat as navigation)
Fixing the priority inversion.

Comment 6 by jochen@chromium.org, Jun 6 2018 

just to manage expectations, not sure I'll get this done for 68..

The plan of action is to cancel the download on a cross origin redirect, and start a new navigation and pass the redirect chain in to LoadURLParams.

Comment 7 by jochen@chromium.org, Jun 14 2018 

 Issue 852203  has been merged into this issue.

Comment 8 by jochen@chromium.org, Jun 27 2018 

 Issue 855820  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e28cbde93b0bfe7d66011774b1c820787be27a9a

commit e28cbde93b0bfe7d66011774b1c820787be27a9a
Author: Jochen Eisinger <jochen@chromium.org>
Date: Fri Jul 13 13:03:42 2018

Add log output if a download triggered by a page redirects cross-origin

The next step will be to figure out how to get back to the initiating
WebContents, dump the redirect chain into a LoadURLParams struct,
and continue the download as navigation.

BUG= 831073 
R=qinmin@chromium.org,dtrainor@chromium.org

Change-Id: I28c55fdc9982433b684184b234f8f503c46facc5
Reviewed-on: https://chromium-review.googlesource.com/1135307
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574890}
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/components/download/public/common/download_response_handler.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/components/download/public/common/download_url_parameters.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/components/download/public/common/download_url_parameters.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/common/frame_messages.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/e28cbde93b0bfe7d66011774b1c820787be27a9a/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc

Comment 10 Deleted

Comment 11 by jochen@chromium.org, Jul 18 

oops, the CL from comment #10 was not related to this issue
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99aa7a800510098a48eb8b6e67c87eb757704745

commit 99aa7a800510098a48eb8b6e67c87eb757704745
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Jul 19 05:02:51 2018

Turn cross-origin downloads into navigations

BUG= 831073 
R=qinmin@chromium.org,clamy@chromium.org

Change-Id: I1c07cd89e06a8b15272ff862d237da5527288b7a
Reviewed-on: https://chromium-review.googlesource.com/1138081
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576376}
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/chrome/common/extensions/api/downloads.idl
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/internal/common/download_create_info.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/public/common/download_create_info.h
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/public/common/download_interrupt_reason_values.h
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/download/public/common/download_response_handler.h
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/components/history/content/browser/content_history_backend_db_unittest.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/content/browser/download/download_request_core.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/99aa7a800510098a48eb8b6e67c87eb757704745/tools/metrics/histograms/enums.xml

Comment 13 by jochen@chromium.org, Jul 19

Labels: -M-68 M-70
Status: Fixed (was: Assigned)

Comment 14 by jochen@chromium.org, Jul 19

Labels: -M-70 M-69
actually, it looks like this was before the branch cut..
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3746729d409d38a3539dbb87a9f276ff6a9ae2f

commit b3746729d409d38a3539dbb87a9f276ff6a9ae2f
Author: Min Qin <qinmin@chromium.org>
Date: Fri Jul 20 01:22:05 2018

Cancel the download request if it is cross origin redirect

For cross origin redirects, Chrome starts a new navigation request.
Since the ResourceDownloader is already created, CancelRequest() is
needed to destroy it.

BUG= 831073 

Change-Id: I97456d6659fd61cf9af39b037fa95a448ab80185
Reviewed-on: https://chromium-review.googlesource.com/1143690
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576747}
[modify] https://crrev.com/b3746729d409d38a3539dbb87a9f276ff6a9ae2f/content/browser/download/download_manager_impl.cc

Comment 17 by jochen@chromium.org, Jul 23

Labels: ReleaseBlock-Beta Merge-Request-69
requesting merge for c0d2e5ec5d6bbe79729b2355c8fc4c65286c9b74 (last commit)

Comment 18 by benmason@google.com, Jul 23

Cc: benmason@chromium.org

Comment 19 by jochen@chromium.org, Jul 23 

the commit is in 70.0.3498.0

I verified that it works. I'd like to merge it, because it fixes a bug I introduced in M69

Comment 20 by benmason@google.com, Jul 23

Labels: -Merge-Request-69 Merge-Approved-69
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 23

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51df0c42374c739a2996c14cb3388d998c2d1b1e

commit 51df0c42374c739a2996c14cb3388d998c2d1b1e
Author: Jochen Eisinger <jochen@chromium.org>
Date: Mon Jul 23 18:48:11 2018

Follow cross-origin redirects when downloading due to alt-click

BUG= 831073 
R=mkwst@chromium.org
TBR=jochen@chromium.org

(cherry picked from commit c0d2e5ec5d6bbe79729b2355c8fc4c65286c9b74)

Change-Id: I99d07c42aa30e73f1efb878b97e4909aeae5ad7d
Reviewed-on: https://chromium-review.googlesource.com/1144822
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576860}
Reviewed-on: https://chromium-review.googlesource.com/1147222
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#21}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/51df0c42374c739a2996c14cb3388d998c2d1b1e/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/51df0c42374c739a2996c14cb3388d998c2d1b1e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/51df0c42374c739a2996c14cb3388d998c2d1b1e/content/test/data/download/download-attribute.html
[modify] https://crrev.com/51df0c42374c739a2996c14cb3388d998c2d1b1e/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/51df0c42374c739a2996c14cb3388d998c2d1b1e/third_party/blink/renderer/core/loader/frame_loader.cc
►

Sign in to add a comment