New issue
Advanced search Search tips

Issue 831059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Text caret disappears after clicking on clear icon in filter text box.

Reported by pranjali...@etouch.net, Apr 10 2018

Issue description

Chrome version : 67.0.3390.0 (Official Build) ae47769a6d274cb8eeca0f8e7b9198d0b043975f-refs/heads/master@{#548636} 32/64 bit

OS : Windows(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and open DevTools.
2. Go to 'console' section and type some text in 'filter' textbox.
3. Now click on clear icon(x) in textbox and observe.

Actual Result : Text caret disappears after clicking on clear icon in filter text box 
Expected Result : Text caret should not disappears after clicking on clear icon in filter text box.

This is a regression issue broken in ‘M-67’ and using the per-revision bisect providing the bisect results,
Good build : 67.0.3381.0 (Revision: 545919)
Bad build : 67.0.3382.0 (Revision: 546346)

You are probably looking for a change made after 546138 (known good), but no later than 546139 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/87cd9251dc4ea7087a41e0f73e53045046854750..2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec

Suspect : https://chromium.googlesource.com/chromium/src/+/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec

@alph: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank you.
 
Actual_result.mp4
481 KB View Download
Expected_result.mp4
452 KB View Download
Owner: l...@chromium.org
Erik, could you please take a look.
Labels: -Pri-1 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdc1f3d342363df455d02fde8bc04d44f5331e5e

commit cdc1f3d342363df455d02fde8bc04d44f5331e5e
Author: Erik Luo <luoe@chromium.org>
Date: Thu Jul 12 19:11:59 2018

DevTools: clicking clear on input should focus

The act of clicking the 'x' clear button blurs focus. This CL ensures
the input focuses afterwards.

Bug:  831059 
Change-Id: I848296c0981873cd878f5aaaead9654809811349
Reviewed-on: https://chromium-review.googlesource.com/1134577
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574664}
[modify] https://crrev.com/cdc1f3d342363df455d02fde8bc04d44f5331e5e/third_party/blink/renderer/devtools/front_end/ui/Toolbar.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Update:

Rechecked the above issue on Windows(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04 LTS) OS using latest canary build#69.0.3493.0 and issue is fixed. Text caret is seen even after clicking on clear icon in filter textbox.

Please find below attached screencast for reference.

Thank You...
Canary_behaviour.mp4
369 KB View Download

Sign in to add a comment