Feature Request: Clarify if the culprit patch will be auto-reverted or not. |
||
Issue descriptionI've seen "Findit found culprit with 100% confidence.", but I couldn't understand how I can take action (I should wait for the auto-revert, or I should revert the CL manually?), though I've read through the "How To Use" in Chrome Culprit Finder: https://sites.google.com/a/chromium.org/cr-culprit-finder/findit/reliable-failure/manual . Probably the statement should be something like "Findit found culprit with 100% confidence, **but won't create/submit the revert patch. Please do it manually.** " Also, "Findit is analyzing..." may need to have similar sentence like "Findit is analyzing... Findit may create/submit the revert patch if a culprit CL is found, so please wait until the analysis finishes." What do you think?
,
Apr 10 2018
I agree that we could make it more clear about the state of analysis by Findit running in the background. Findit has two phases in the analysis: 1. Heuristic analysis: takes 1~2 minutes, result is not confirmed with rerun yet, so it still needs a manual double check. 2. Rerun-based analysis: rerunning a compile/test failure takes 15~30 minutes usually and sometimes could be 1+ hour, but the result is usually reliable unless we run into a low flakiness. For result from 1, we'd better make it clear that Findit is confirming with a rerun and sheriff could wait. For result from 2, we'd better make it clear that either Findit has taken automatic action or a manual action is needed from sheriffs. chanli@, as you own the Findit-SoM integration, would you mind taking from here and making the change?
,
Apr 10 2018
Sure, I'll add this improvement in my queue. |
||
►
Sign in to add a comment |
||
Comment 1 by seanmccullough@chromium.org
, Apr 10 2018Labels: Milestone-Polish
Status: Available (was: Untriaged)