New issue
Advanced search Search tips

Issue 831036 link

Starred by 1 user
Status: Duplicate
Merged: issue 830629
Owner:
qyears...@chromium.org
Closed: Apr 2018
Cc:
qyears...@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

mac_10.12_blink_rel doesn't run layout tests, causing webkit-rebaseline cl to fail

Project Member Reported by wangxianzhu@chromium.org, Apr 10 2018 
https://chromium-review.googlesource.com/c/chromium/src/+/999095/8 contains rebaselined result created based on https://chromium-review.googlesource.com/c/chromium/src/+/999095/7. However, mac_chromium_rel_ng still failed at the tests that have been rebaselined for the rebaseline-cl bots.

I run webkit-patch rebaseline-cl again on https://chromium-review.googlesource.com/c/chromium/src/+/999095/8, but all rebaseline-cl bots passed. It seems that mac_chromium_rel_ng uses baselines that are all different from the new baselines.

Comment 1 by wangxianzhu@chromium.org, Apr 10 2018 

https://chromium-review.googlesource.com/c/chromium/src/+/1001752 seems of the same situation.

It seems that the same mac baselines are created under multiple directories:,mac-mac10.10/, mac-mac10.11/, mac-retina/, mac/ directories, while the newly created baselines under mac-mac10.12 look bogus.

Comment 2 by wangxianzhu@chromium.org, Apr 10 2018

Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
I think I found the reason: mac_10.12_blink_rel didn't run layout tests and it was green, so no new baselines were created for mac-mac10.12.

qyearsley@ can you take a look?

Comment 3 by wangxianzhu@chromium.org, Apr 10 2018 

For now I can use the following workaround:
1. Open the layout test result page on mac_chromium_rel_ng;
2. Select "Rebaseline script" format, and copy report;
3. In local directory LayoutTests/platform/mac-mac10.12, <paste>
4. In the test result page, click "Copy single line"
5. webkit-patch optimize-baselines <paste>

Comment 4 by wangxianzhu@chromium.org, Apr 10 2018

Summary: mac_10.12_blink_rel doesn't run layout tests, causing webkit-rebaseline cl to fail (was: After webkit-patch rebaseline-cl, all mac bots pass, but mac_chromium_rel_ng still fails)

Comment 5 by robertma@chromium.org, Apr 10 2018

Mergedinto: 830629
Status: Duplicate (was: Assigned)
►

Sign in to add a comment