New issue
Advanced search Search tips

Issue 831034 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Create autotests that interrupt a regular update

Project Member Reported by dhadd...@chromium.org, Apr 10 2018

Issue description

This is automating section 1.2 of our manual tests:
https://testtracker.googleplex.com/testplans/details/450

We already have some interruption code for the forced oobe tests that we can reuse. I will need to probably move some of this functionality to the base class
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/80e3b8f96c082d08bba352e032e8a8fb08e30e8d

commit 80e3b8f96c082d08bba352e032e8a8fb08e30e8d
Author: David Haddock <dhaddock@chromium.org>
Date: Sun Apr 22 18:42:30 2018

Refactor server side code a bit ahead of last few AU tests.

We want to share common code between the client and server base classes.
To do this I have introduced a new class update_engine_util. It will
hold common variables and methods.

The client and server base classes will then use multiple inheritance.
To inherit from update_engine_util and the standard autotest test class.

The differences between the client and server is the run() function
used: either utils.run for client or host.run for server. The will be
defined in the initialize() function of each base class.

BUG= chromium:831034 
BUG= chromium:817913 
TEST=OOBE regular test, OOBE interrupt, new interrupt test, bad sha256

Change-Id: I4c22a8485c0ec30e27518de153371ec0cffba84d
Reviewed-on: https://chromium-review.googlesource.com/1010884
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[add] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/cros/update_engine/update_engine_util.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/site_tests/autoupdate_EOL/autoupdate_EOL.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/site_tests/autoupdate_NonBlockingOOBEUpdate/autoupdate_NonBlockingOOBEUpdate.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/site_tests/autoupdate_UrlSwitch/autoupdate_UrlSwitch.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/cros/update_engine/omaha_devserver.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/site_tests/autoupdate_P2P/autoupdate_P2P.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/site_tests/autoupdate_Backoff/autoupdate_Backoff.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/site_tests/autoupdate_StartOOBEUpdate/autoupdate_StartOOBEUpdate.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/site_tests/autoupdate_Cellular/autoupdate_Cellular.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/cros/update_engine/update_engine_test.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/cros/update_engine/update_engine_test.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/client/site_tests/autoupdate_BadMetadata/autoupdate_BadMetadata.py
[modify] https://crrev.com/80e3b8f96c082d08bba352e032e8a8fb08e30e8d/server/site_tests/autoupdate_ForcedOOBEUpdate/autoupdate_ForcedOOBEUpdate.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aebfe0b3e568e14b9de3d7428648533cf35b821c

commit aebfe0b3e568e14b9de3d7428648533cf35b821c
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Apr 27 19:22:33 2018

Add a test which interrupts a regular update.

We already have a test for interrupting an update during OOBE.
This will do the same for a regular update.

The test will log into Chrome, start an update, then log out.
It will reboot, pull network, suspend/resume.
It will add a new user and crash the browser.
Then ensure that the update completes successfully.

BUG= chromium:831034 
TEST=autoupdate_Interruptions.full

Change-Id: Id1029da9f75b526cbf17802d4a3060ffdf9586df
Reviewed-on: https://chromium-review.googlesource.com/1011237
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: David Haddock <dhaddock@chromium.org>

[modify] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/cros/update_engine/update_engine_util.py
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/site_tests/autoupdate_CrashBrowserAfterUpdate/control
[modify] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/server/site_tests/autoupdate_NonBlockingOOBEUpdate/autoupdate_NonBlockingOOBEUpdate.py
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/site_tests/autoupdate_LoginStartUpdateLogout/autoupdate_LoginStartUpdateLogout.py
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/server/site_tests/autoupdate_Interruptions/autoupdate_Interruptions.py
[modify] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/site_tests/autoupdate_DisconnectReconnectNetwork/autoupdate_DisconnectReconnectNetwork.py
[modify] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/server/site_tests/autoupdate_ForcedOOBEUpdate/autoupdate_ForcedOOBEUpdate.py
[modify] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/cros/update_engine/update_engine_test.py
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/site_tests/autoupdate_CrashBrowserAfterUpdate/autoupdate_CrashBrowserAfterUpdate.py
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/client/site_tests/autoupdate_LoginStartUpdateLogout/control
[add] https://crrev.com/aebfe0b3e568e14b9de3d7428648533cf35b821c/server/site_tests/autoupdate_Interruptions/control.full

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0856862ea52e68c73005072099bc32f38bc59668

commit 0856862ea52e68c73005072099bc32f38bc59668
Author: David Haddock <dhaddock@chromium.org>
Date: Sat Apr 28 04:27:41 2018

Add new AU tests to ebuild.

Server: autoupdate_Interruptions.
Client: autoupdate_CrashBrowserAfterUpdate, autoupdate_LoginStartUpdateLogout.

BUG= chromium:831034 
TEST=None

Change-Id: Ie67280b7be597edd33eb645dbb9519065f68e57d
Reviewed-on: https://chromium-review.googlesource.com/1011402
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: David Haddock <dhaddock@chromium.org>

[modify] https://crrev.com/0856862ea52e68c73005072099bc32f38bc59668/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild
[modify] https://crrev.com/0856862ea52e68c73005072099bc32f38bc59668/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Status: Verified (was: Assigned)

Sign in to add a comment