New issue
Advanced search Search tips

Issue 831032 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Modern Media Controls: Add shadow to overlay play button

Project Member Reported by steimel@chromium.org, Apr 10 2018

Issue description

The overlay play button is difficult to see against a video with a white background. Per these specs, it should have a shadow:
https://folio.googleplex.com/mediacontrolspec/specs/Media-Controls_Android_AR_UIreview
 
Here are screenshots showing before and after the change with a white video
crrev.1004112.before_change.png
14.6 KB View Download
crrev.1004112.after_change.png
16.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442e46708ff8a813c55df22e7061f0b4396301fc

commit 442e46708ff8a813c55df22e7061f0b4396301fc
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Apr 10 18:19:18 2018

Add shadow to overlay play button

This CL adds a shadow to the overlay play button so that it's visible
against white backgrounds.

Bug:  831032 
Change-Id: If9af93e25efe8a1e1b3cf802629a15c3e2d0597e
Reviewed-on: https://chromium-review.googlesource.com/1004112
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549594}
[modify] https://crrev.com/442e46708ff8a813c55df22e7061f0b4396301fc/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tried checking the issue on chrome versions 67.0.3393.0 and 67.0.3394.0 using Mac 10.13.1 with the below mentioned steps.
1. Launched Chrome
2. Navigated to https://jsfiddle.net/9af830ne/
We observed similar behaviour in both the versions while playing video and pausing it with respect to shadow on play button.

@Tommy Steimel: As we are unable to access the link provided in comment#0 can you please provide us with an other test file which helps us to verify the issue in a better way.

Thanks!

Sign in to add a comment