New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831028 link

Starred by 1 user
Status: Fixed
Owner:
riajiang@chromium.org
Closed: Apr 2018
Cc:
█ brajkumar@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Stack-overflow in mojo::StructPtr<viz::mojom::HitTestRegionList>::StructPtr<>

Project Member Reported by ClusterFuzz, Apr 10 2018 
Detailed report: https://clusterfuzz.com/testcase?key=4704574812979200

Fuzzer: libFuzzer_hit_test_manager_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff53016ff8
Crash State:
  mojo::StructPtr<viz::mojom::HitTestRegionList>::StructPtr<>
  mojo::StructPtr<viz::mojom::HitTestRegionList> viz::mojom::HitTestRegionList::Ne
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=546150:546359

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4704574812979200

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
Project Member

Comment 1 by ClusterFuzz, Apr 10 2018

Components: Internals>Mojo
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by brajkumar@chromium.org, Apr 10 2018

Cc: brajkumar@chromium.org
Labels: -Type-Bug M-67 Test-Predator-Wrong Type-Bug-Regression
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

From the below CL observing some changes related to 'HitTestRegionList' , hence suspecting the same
https://chromium.googlesource.com/chromium/src/+log/a783ac29716b05560ef605df0e9d2665ab3010bd..1ea449dcf22ac62402c9383fc17bc121e613fcef?pretty=fuller&n=10000

Suspect CL: https://chromium.googlesource.com/chromium/src/+/4361dcb9a14ccbf76b21abc3c3592a905430c3b1

khushalsagar@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 3 by khushals...@chromium.org, Apr 10 2018

Owner: riajiang@chromium.org
Looks like the fuzzer was added within the regression range (https://chromium.googlesource.com/chromium/src/+/337a57b9b3be8a2f7dab252c4d4d90ff44bbc2b3).
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a49113392b0c716829dcb2cad847a8a210e2a1b

commit 3a49113392b0c716829dcb2cad847a8a210e2a1b
Author: Ria Jiang <riajiang@chromium.org>
Date: Wed Apr 11 22:37:04 2018

Fix stack-overflow in hit_test_manager_fuzzer.

Fix stack-overflow in hit_test_manager_fuzzer by limiting how many
levels of embedding we can have in hit-test data.

Updated coverage report: (still ~98%)
https://goto.google.com/riajiang-hit-test-fuzzer-report-update

Bug:  830183 ,  831028 ,  831029 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I53e2203fe47c94b915a4ad1cfee65b5a3b50cc5d
Reviewed-on: https://chromium-review.googlesource.com/1007963
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549960}
[modify] https://crrev.com/3a49113392b0c716829dcb2cad847a8a210e2a1b/components/viz/service/hit_test/hit_test_manager_fuzzer.cc

Comment 5 by riajiang@chromium.org, Apr 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment