New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831004 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Apr 2018
Cc:
calamity@chromium.org
█ sashab@chromium.org
joelhockey@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 833656
Blocking:
issue 815009



Sign in to add a comment

Roll closure compiler to latest version

Project Member Reported by dpa...@chromium.org, Apr 10 2018 
Closure compiler has not been rolled to a new version for a fairly long time, since Aug 2017, see [1]. As part of updating iron-list to its latest version ( issue 815009 ), need to also roll the compiler to pick up latest Polymer 2 externs.

Doing so revealed a bunch new (legit) type errors, which indicates that the compiler got smarter and more strict. These errors need to be fixed before rolling the new version.

Also, as part of fixing https://github.com/google/closure-compiler/issues/1189, chrome.js externs are now not included by default, which requires tweaking our own roll_closure_compiler script (and some more).

Original WIP CL from scottchen@ is at [2]. I am taking over this task while Scott is OOO.

[1] https://chromium-review.googlesource.com/592719
[2] https://chromium-review.googlesource.com/c/chromium/src/+/592719

Comment 1 by dpa...@chromium.org, Apr 10 2018

Blocking: 815009

Comment 2 by dpa...@chromium.org, Apr 10 2018

Cc: sashab@chromium.org joelhockey@chromium.org
Status update: I've fixed all newly found compiler errors locally. Those errors need to be fixed before actually rolling the compiler to the latest version. The entire task is currently broken down to three CLs.

1) Fixing Chrome OS file manager errors: https://chromium-review.googlesource.com/c/chromium/src/+/1006179
2) Fixing other WebUI errors: https://chromium-review.googlesource.com/c/chromium/src/+/1006195
3) Rolling closure compiler: https://chromium-review.googlesource.com/c/chromium/src/+/1006182
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/927e8f292599766261c4ca2837d29a7e74184ed2

commit 927e8f292599766261c4ca2837d29a7e74184ed2
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 12 07:27:47 2018

File manager: Fix newly found Closure compiler errors.

Latest version of Closure compiler is smarter and stricter. The errors
need to be fixed to unblock rolling the latest Closure compiler version.

Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e22cfd40d621263532206e2f816048c6e6a3778
Reviewed-on: https://chromium-review.googlesource.com/1006179
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550071}
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/externs/background/import_history.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/background/js/file_operation_manager.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/background/js/file_operation_util.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/background/js/import_history.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/background/js/media_import_handler.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/common/js/mock_entry.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/file_selection.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/toolbar_controller.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/ui/default_task_dialog.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/gallery/js/image_editor/image_view.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/file_manager/video_player/js/video_player.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/webui/resources/js/cr/ui/autocomplete_list.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/webui/resources/js/cr/ui/list.js
[modify] https://crrev.com/927e8f292599766261c4ca2837d29a7e74184ed2/ui/webui/resources/js/cr/ui/table/table_header.js
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0863b8b7b81acaf8f65a0bae481925007fd3f81

commit a0863b8b7b81acaf8f65a0bae481925007fd3f81
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 12 19:34:24 2018

WebUI: Fix newly found Closure compiler errors.

Latest version of Closure compiler is smarter and stricter. The errors
need to be fixed to unblock rolling the latest Closure compiler version.

Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5cf2abbcba1a209e28fb826b16f57e5dbd084853
Reviewed-on: https://chromium-review.googlesource.com/1006195
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550311}
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/bookmark_manager/js/dnd.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/bookmark_manager/js/main.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/chromeos/kiosk_apps.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_code.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_error_overlay.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_list.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_loader.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extensions.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/apps_page.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/page_list_view.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/tile_page.js
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a301a4eb66b3f53b2e5157019a8382805efda2c

commit 1a301a4eb66b3f53b2e5157019a8382805efda2c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 13 03:44:35 2018

Settings: Internet: Fix 'type' params in events

Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55a1de65656bb646b9954dfafa5199dc3667867e
Reviewed-on: https://chromium-review.googlesource.com/1010913
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550503}
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/network_summary_item.js
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf4606b9631e94d9b99255ff4e4091657d2fb42

commit cdf4606b9631e94d9b99255ff4e4091657d2fb42
Author: dpapad <dpapad@chromium.org>
Date: Mon Apr 16 18:55:43 2018

Roll closure compiler

Latest compiler version does not include Chrome's externs by default. They
need to be explicitly included.

Change log:
https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66

BUG= 831004 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
Reviewed-on: https://chromium-review.googlesource.com/1006182
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551058}
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/ntp4/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compiler/compiler.jar
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compiler_test.py
[add] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/chrome.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/chrome_extensions.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/polymer-1.0.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/roll_closure_compiler
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/tools/create_include_gyp.py

Comment 8 by dpa...@chromium.org, Apr 16 2018

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd

commit e97d8d429ea6d4a42a992fbecb21d96b29aa68bd
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Mon Apr 16 23:41:51 2018

Revert "Roll closure compiler"

This reverts commit cdf4606b9631e94d9b99255ff4e4091657d2fb42.

Reason for revert: Apparently some bots have java 1.8, some have 1.7 which caused flakiness. Need to update all bots to 1.8 before re-landing.

Original change's description:
> Roll closure compiler
> 
> Latest compiler version does not include Chrome's externs by default. They
> need to be explicitly included.
> 
> Change log:
> https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
> chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
> chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
> polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66
> 
> BUG= 831004 
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
> Reviewed-on: https://chromium-review.googlesource.com/1006182
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551058}

TBR=calamity@chromium.org,dpapad@chromium.org

Change-Id: I1d8bfeb4a6b79b7098cf2b1e4e975cacbd8f00ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1013548
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551171}
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/ntp4/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compiler/compiler.jar
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compiler_test.py
[delete] https://crrev.com/3d03e058a8882f58c8c8ee5518d804f176423091/third_party/closure_compiler/externs/chrome.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/chrome_extensions.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/polymer-1.0.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/roll_closure_compiler
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/tools/create_include_gyp.py

Comment 10 by dpa...@chromium.org, Apr 16 2018

Blockedon: 833656
Status: Started (was: Fixed)
Unfortunately the previous CL needs to be reverted for now, due issues with java 1.8 on the bots.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0863b8b7b81acaf8f65a0bae481925007fd3f81

commit a0863b8b7b81acaf8f65a0bae481925007fd3f81
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 12 19:34:24 2018

WebUI: Fix newly found Closure compiler errors.

Latest version of Closure compiler is smarter and stricter. The errors
need to be fixed to unblock rolling the latest Closure compiler version.

Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5cf2abbcba1a209e28fb826b16f57e5dbd084853
Reviewed-on: https://chromium-review.googlesource.com/1006195
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550311}
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/bookmark_manager/js/dnd.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/bookmark_manager/js/main.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/chromeos/kiosk_apps.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_code.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_error_overlay.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_list.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extension_loader.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/extensions/extensions.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/apps_page.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/page_list_view.js
[modify] https://crrev.com/a0863b8b7b81acaf8f65a0bae481925007fd3f81/chrome/browser/resources/ntp4/tile_page.js
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a301a4eb66b3f53b2e5157019a8382805efda2c

commit 1a301a4eb66b3f53b2e5157019a8382805efda2c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 13 03:44:35 2018

Settings: Internet: Fix 'type' params in events

Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55a1de65656bb646b9954dfafa5199dc3667867e
Reviewed-on: https://chromium-review.googlesource.com/1010913
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550503}
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/1a301a4eb66b3f53b2e5157019a8382805efda2c/chrome/browser/resources/settings/internet_page/network_summary_item.js
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf4606b9631e94d9b99255ff4e4091657d2fb42

commit cdf4606b9631e94d9b99255ff4e4091657d2fb42
Author: dpapad <dpapad@chromium.org>
Date: Mon Apr 16 18:55:43 2018

Roll closure compiler

Latest compiler version does not include Chrome's externs by default. They
need to be explicitly included.

Change log:
https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66

BUG= 831004 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
Reviewed-on: https://chromium-review.googlesource.com/1006182
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551058}
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/chrome/browser/resources/ntp4/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compiler/compiler.jar
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/compiler_test.py
[add] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/chrome.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/chrome_extensions.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/externs/polymer-1.0.js
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/roll_closure_compiler
[modify] https://crrev.com/cdf4606b9631e94d9b99255ff4e4091657d2fb42/third_party/closure_compiler/tools/create_include_gyp.py
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd

commit e97d8d429ea6d4a42a992fbecb21d96b29aa68bd
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Mon Apr 16 23:41:51 2018

Revert "Roll closure compiler"

This reverts commit cdf4606b9631e94d9b99255ff4e4091657d2fb42.

Reason for revert: Apparently some bots have java 1.8, some have 1.7 which caused flakiness. Need to update all bots to 1.8 before re-landing.

Original change's description:
> Roll closure compiler
> 
> Latest compiler version does not include Chrome's externs by default. They
> need to be explicitly included.
> 
> Change log:
> https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
> chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
> chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
> polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66
> 
> BUG= 831004 
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
> Reviewed-on: https://chromium-review.googlesource.com/1006182
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551058}

TBR=calamity@chromium.org,dpapad@chromium.org

Change-Id: I1d8bfeb4a6b79b7098cf2b1e4e975cacbd8f00ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1013548
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551171}
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/chrome/browser/resources/ntp4/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compiler/compiler.jar
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/compiler_test.py
[delete] https://crrev.com/3d03e058a8882f58c8c8ee5518d804f176423091/third_party/closure_compiler/externs/chrome.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/chrome_extensions.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/externs/polymer-1.0.js
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/roll_closure_compiler
[modify] https://crrev.com/e97d8d429ea6d4a42a992fbecb21d96b29aa68bd/third_party/closure_compiler/tools/create_include_gyp.py
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce

commit 9d788440d8b6e3dfcbf845d234d7b1311e6a1bce
Author: dpapad <dpapad@chromium.org>
Date: Tue Apr 17 20:04:27 2018

Reland "Roll closure compiler"

This is a reland of cdf4606b9631e94d9b99255ff4e4091657d2fb42.
Retrying to land this now that crbug.com/833656 is fixed.

Original change's description:
> Roll closure compiler
>
> Latest compiler version does not include Chrome's externs by default. They
> need to be explicitly included.
>
> Change log:
> https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925
> chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9
> chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc
> polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66
>
> BUG= 831004 
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9
> Reviewed-on: https://chromium-review.googlesource.com/1006182
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551058}

TBR=calamity

Bug:  831004 
Change-Id: I0966b1a07da3b6318fb22a6bc6393eb499446743
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1015180
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551445}
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/chrome/browser/resources/ntp4/compiled_resources2.gyp
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/compiler/compiler.jar
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/compiler_test.py
[add] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/externs/chrome.js
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/externs/chrome_extensions.js
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/externs/compiled_resources2.gyp
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/externs/polymer-1.0.js
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/roll_closure_compiler
[modify] https://crrev.com/9d788440d8b6e3dfcbf845d234d7b1311e6a1bce/third_party/closure_compiler/tools/create_include_gyp.py

Comment 16 by dpa...@chromium.org, Apr 20 2018

Cc: dbeam@chromium.org
Status: Fixed (was: Started)
Note to self: We should be rolling Closure compiler periodically, so that updates are not as involved as this one. Also per dbeam@, he used to roll about once a month in the past.
►

Sign in to add a comment