New issue
Advanced search Search tips

Issue 830993 link

Starred by 1 user
Status: Duplicate
Owner:
jianli@chromium.org
Closed: Apr 2018
Cc:
crouleau@chromium.org
carlosk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Flaky test] OfflinePageRequestJobTest

Project Member Reported by gab@chromium.org, Apr 10 2018 
On https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/

OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment

[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (177 ms)
[----------] 2 tests from OfflinePageRequestJobTest (392 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (394 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (172 ms)
[----------] 2 tests from OfflinePageRequestJobTest (345 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (346 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (140 ms)
[----------] 2 tests from OfflinePageRequestJobTest (357 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (358 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage

Comment 1 by carlosk@chromium.org, Apr 10 2018

Labels: OS-Android
Status: WontFix (was: Assigned)
I looked at all failures starting at build #524747 up until 200 back in history. I only found this error in a single purple run of this bot, what generally means there was an infra issue during the execution: 
https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/524633

All other failures did not refer to these tests. Also this bot seems quite unstable -- lost of red and purple -- so it really seems the problem is not related to the tests themselves.

Comment 2 by gab@chromium.org, Apr 10 2018 

This isn't a timeout though, a flake on expected values usually indicates a flaky test. Maybe it only flakes under rare conditions that exercises the race but there is a race nonetheless.

Comment 3 by carlosk@chromium.org, Apr 11 2018

Cc: carlosk@chromium.org
Labels: -Pri-2 Pri-3
Owner: jianli@chromium.org
Status: Assigned (was: WontFix)
OK, I see your point. This indeed would be better handled if it didn't depend on timing but on an actual barrier with a timeout on receiving the callbacks from the Request placed in the IO thread.

I'm reassigning to jianli@ with a low priority given it hasn't been a problem normally on the bots.

Comment 4 by jianli@chromium.org, Apr 11 2018

Mergedinto: 830282
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/5c3e2a9f56279eee55f20861f7defa1eeb0915a9

commit 5c3e2a9f56279eee55f20861f7defa1eeb0915a9
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Apr 24 20:57:32 2018
►

Sign in to add a comment