Come up with a good name for common Posix/Fuchsia configurations |
||
Issue descriptionWhile doing the necessary changes for issue 812974 it became clear we are lacking a good name for a common name for common Posix/Fuchsia configurations and code paths that won't be ultimately different. Random (bad) ideas: -pochsia -fuchsix -not_windows -unix_like -something really good that I haven't thought of
,
Jan 10
I remember we had a discussion about this a while ago and came to the conclusion that we should just say we are explicitly choosing to include Posix-behavior in specific parts of the codebase. I'm going to update the comment with that bug to reflect that decision.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea8c8a4810f55c3cd8b5d4a524768a766d6da234 commit ea8c8a4810f55c3cd8b5d4a524768a766d6da234 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Jan 10 23:03:42 2019 Clarify a comment about Fuchsia sharing a configuration with POSIX. It was decided that instances of |posix or fuchsia| in the build or source files would mean that Fuchsia is explicitly using POSIX behavior. Bug: 830987 Test: No-op Change-Id: If90cd5bfcdba8cd1e60af23e3ede992d9f16fc0b Reviewed-on: https://chromium-review.googlesource.com/c/1404424 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#621788} [modify] https://crrev.com/ea8c8a4810f55c3cd8b5d4a524768a766d6da234/build/config/posix/BUILD.gn
,
Jan 10
|
||
►
Sign in to add a comment |
||
Comment 1 by fdegans@chromium.org
, Apr 10 2018